From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F3A3C43462 for ; Tue, 18 May 2021 10:06:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DD48D613B5 for ; Tue, 18 May 2021 10:06:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348322AbhERKIC (ORCPT ); Tue, 18 May 2021 06:08:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51262 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241178AbhERKIB (ORCPT ); Tue, 18 May 2021 06:08:01 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7F7E9C061573; Tue, 18 May 2021 03:06:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=XcUE59BbQI5VCk62NQ98jAv25zo//emUHUedcxxcgyA=; b=B+1u6ZG4uJf1OSsB0tVOyeq0N H+f35qC+o3JQhJf0dqEAUIURiaEown3+hepXFL/kFsdRe5AnAXhCIr6odFUcrSryaajMcfXd7lHSV oERv2lMclyCkH88TtgEHbvmIjNuiaaskphGn/68qNsJVObsFzkALdGKWJnX2FP1mqe6ytC45X9SUH JOZlL7c8SLi92/bJOPHxXqYy/CdA1jei51V5eRNuZvzT7bn/n+6/NXPoPu+KSzaxpEWV+9shIdC8z pzsC2s8JthkHOanWWYH+W3ao8o0rzYPudZqRQqUkWQJea5CTgYcaXde0QKP4Qyg7/QjPw/chMtbu+ FgWLQSc9Q==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:44126) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1liwcR-00042a-B7; Tue, 18 May 2021 11:06:31 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1liwcN-0007nP-Tc; Tue, 18 May 2021 11:06:27 +0100 Date: Tue, 18 May 2021 11:06:27 +0100 From: "Russell King (Oracle)" To: "Sit, Michael Wei Hong" Cc: "Jose.Abreu@synopsys.com" , "andrew@lunn.ch" , "hkallweit1@gmail.com" , "kuba@kernel.org" , "netdev@vger.kernel.org" , "peppe.cavallaro@st.com" , "alexandre.torgue@foss.st.com" , "davem@davemloft.net" , "mcoquelin.stm32@gmail.com" , "Voon, Weifeng" , "Ong, Boon Leong" , "Tan, Tee Min" , "vee.khee.wong@linux.intel.com" , "Wong, Vee Khee" , "linux-stm32@st-md-mailman.stormreply.com" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH net-next 2/2] net: stmmac: Add callbacks for DWC xpcs Energy Efficient Ethernet Message-ID: <20210518100627.GT12395@shell.armlinux.org.uk> References: <20210517094332.24976-1-michael.wei.hong.sit@intel.com> <20210517094332.24976-3-michael.wei.hong.sit@intel.com> <20210517105424.GP12395@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: Russell King (Oracle) Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, May 17, 2021 at 11:37:12AM +0000, Sit, Michael Wei Hong wrote: > > From: Russell King > > > > On Mon, May 17, 2021 at 05:43:32PM +0800, Michael Sit Wei Hong > > wrote: > > > Link xpcs callback functions for MAC to configure the xpcs EEE > > feature. > > > > > > The clk_eee frequency is used to calculate the > > MULT_FACT_100NS. This > > > is to adjust the clock tic closer to 100ns. > > > > > > Signed-off-by: Michael Sit Wei Hong > > > > > > What is the initial state of the EEE configuration before the first > > call to stmmac_ethtool_op_set_eee()? Does it reflect the default > > EEE settings? > > The register values before the first call are the default reset values in > the registers. The reset values assumes the clk_eee_i time period is 10ns, > Hence, the reset value is set to 9. > According to the register description, > This value should be programmed such that the > clk_eee_i_time_period * (MULT_FACT_100NS + 1) should be > within 80 ns to 120 ns. > > Since we are using a fixed 19.2MHz clk_eee, which is 52ns, > we are setting the value to 1. Does that hardware default configuration match what is returned by ethtool --show-eee ? -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!