* remove unnecessary brackets
@ 2021-05-24 3:58 dzp
2021-05-24 4:43 ` Willy Tarreau
0 siblings, 1 reply; 2+ messages in thread
From: dzp @ 2021-05-24 3:58 UTC (permalink / raw)
To: edumazet, davem, yoshfuji, dsahern, kuba, netdev, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 88 bytes --]
hi list,
this patch remove unnecessary brackets for ipv4/tcp_output.c
best regards
[-- Attachment #2: 0001-ipv4-tcp_output-remove-unnecessary-brackets.patch --]
[-- Type: application/octet-stream, Size: 800 bytes --]
From d736a5e4a966bbffed90a0647719dde750b29d06 Mon Sep 17 00:00:00 2001
From: Zhiping du <zhipingdu@tencent.com>
Date: Mon, 24 May 2021 03:37:36 +0800
Subject: [PATCH] ipv4:tcp_output:remove unnecessary brackets
There are too many brackets. Maybe only one bracket is enough.
Signed-off-by: Zhiping Du <zhipingdu@tencent.com>
diff --git a/net/ipv4/tcp_output.c b/net/ipv4/tcp_output.c
index bde781f..5455de3 100644
--- a/net/ipv4/tcp_output.c
+++ b/net/ipv4/tcp_output.c
@@ -2620,7 +2620,7 @@ static bool tcp_write_xmit(struct sock *sk, unsigned int mss_now, int nonagle,
}
max_segs = tcp_tso_segs(sk, mss_now);
- while ((skb = tcp_send_head(sk))) {
+ while (skb = tcp_send_head(sk)) {
unsigned int limit;
if (unlikely(tp->repair) && tp->repair_queue == TCP_SEND_QUEUE) {
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: remove unnecessary brackets
2021-05-24 3:58 remove unnecessary brackets dzp
@ 2021-05-24 4:43 ` Willy Tarreau
0 siblings, 0 replies; 2+ messages in thread
From: Willy Tarreau @ 2021-05-24 4:43 UTC (permalink / raw)
To: dzp; +Cc: edumazet, davem, yoshfuji, dsahern, kuba, netdev, linux-kernel
On Mon, May 24, 2021 at 11:58:43AM +0800, dzp wrote:
> hi list,
> this patch remove unnecessary brackets for ipv4/tcp_output.c
>
> best regards
>
>
> From d736a5e4a966bbffed90a0647719dde750b29d06 Mon Sep 17 00:00:00 2001
> From: Zhiping du <zhipingdu@tencent.com>
> Date: Mon, 24 May 2021 03:37:36 +0800
> Subject: [PATCH] ipv4:tcp_output:remove unnecessary brackets
>
> There are too many brackets. Maybe only one bracket is enough.
>
> Signed-off-by: Zhiping Du <zhipingdu@tencent.com>
>
> diff --git a/net/ipv4/tcp_output.c b/net/ipv4/tcp_output.c
> index bde781f..5455de3 100644
> --- a/net/ipv4/tcp_output.c
> +++ b/net/ipv4/tcp_output.c
> @@ -2620,7 +2620,7 @@ static bool tcp_write_xmit(struct sock *sk, unsigned int mss_now, int nonagle,
> }
>
> max_segs = tcp_tso_segs(sk, mss_now);
> - while ((skb = tcp_send_head(sk))) {
> + while (skb = tcp_send_head(sk)) {
Please do not do this. They're here to avoid a compiler warning which
will suggest that it might be a "==" instead of "=", or will ask to add
extra parenthesis.
You've probably seen it when you compiled your patched code.
Willy
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-05-24 4:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-05-24 3:58 remove unnecessary brackets dzp
2021-05-24 4:43 ` Willy Tarreau
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).