Re: [PATCH net-next 09/13] dt-bindings: net: dsa: sja1105: add compatible strings for SJA1110

Vladimir Oltean
2021-05-25T11:57:45Z

On Mon, May 24, 2021 at 07:24:36PM -0700, Florian Fainelli wrote:
> On 5/24/2021 4:22 PM, Vladimir Oltean wrote:
> > From: Vladimir Oltean <vladimir.oltean@nxp.com>
> >
> > There are 4 variations of the SJA1110 switch which have a different set
> > of MII protocols supported per port. Document the compatible strings.
> >
> > Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
>
> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
>
> Time to YAMLify that binding?

I'm afraid that will sidetrack in another discussion about
sja1105,role-mac and sja1105,role-phy which I'm not prepared to have
right now. Those boolean properties are to my knowledge unused, so I
could remove them, but the phy-mode = "mii" + sja1105,role-phy would
have to be replaced with phy-mode = "revmii" and similarly, a new
phy-mode would have to be introduced for phy-mode = "revrmii" or
something.