Re: [PATCH net-next 11/13] net: dsa: sja1105: register the MDIO buses for 100base-T1 and 100base-TX

Andrew Lunn
2021-05-25T13:17:22Z

> > It however sounds like you have the two busses one level deeper?
> >
> > It would be good if you document this as part of the binding.
>
> Yes, it looks like this:
>
> ethernet-switch@2 {
> compatible = "nxp,sja1110a";
>
> ethernet-ports {
> ...
> };
>
> mdio {
> #address-cells = <1>;
> #size-cells = <0>;
>
> mdio@0 {
> reg = <0>;
> compatible = "nxp,sja1110-base-t1-mdio";
> #address-cells = <1>;
> #size-cells = <0>;
>
> sw2_port5_base_t1_phy: ethernet-phy@1 {
> compatible = "ethernet-phy-ieee802.3-c45";
> reg = <0x1>;
> };
>
> ...
> };
>

We should run this by Rob.

That is probably not the intention of
Documentation/devicetree/bindings/net/mdio.yaml, it works because of
additionalProperties: true

What meaning does reg have, in mdio@0?

Andrew