From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DBD86C47089 for ; Wed, 26 May 2021 15:25:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C79CA61378 for ; Wed, 26 May 2021 15:25:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235564AbhEZP0h (ORCPT ); Wed, 26 May 2021 11:26:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46158 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235436AbhEZP02 (ORCPT ); Wed, 26 May 2021 11:26:28 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4A304C061574 for ; Wed, 26 May 2021 08:24:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=uCTItdnypiuWdMwstryWGwGwwkVVIUFMP0duwqhgKTA=; b=BT9ISJkQhpIWhq/kUbtKgn0JG jXZP84PobnaRZmpiX7kfMwcncMbF1LwZGQQtlTVgNzOLcGAXVg9jayCKCvWLbaezrdXuE3a0H1QNU V74fzMX0ETZa/OLgDIFISx6wBd94gNUtlUldOj5CwuOKYd3iNj2sdtXlrO4o9V+zRUMZNcTl9E0z7 TrNdENa9gubXdyPpfdkx8UNQOnXXyCZBtfIdEMV5JiJ93z8qwilststhzvmwOluf1YAGHltwNjZ/v a6E+HryVgMJqR1ycQ62L2GrkY/mcWTCn0hFKqlsAE7zgUC/Wl+OpLaZHV+VPDUATP8hmVlGOarEwG 2MOd3470g==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:44378) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1llvOw-0005q9-QR; Wed, 26 May 2021 16:24:54 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1llvOw-0002un-8g; Wed, 26 May 2021 16:24:54 +0100 Date: Wed, 26 May 2021 16:24:54 +0100 From: "Russell King (Oracle)" To: Vladimir Oltean Cc: Jakub Kicinski , "David S. Miller" , netdev@vger.kernel.org, Florian Fainelli , Andrew Lunn , Vivien Didelot , Heiner Kallweit Subject: Re: [RFC PATCH v2 linux-next 03/14] net: dsa: sja1105: the 0x1F0000 SGMII "base address" is actually MDIO_MMD_VEND2 Message-ID: <20210526152454.GG30436@shell.armlinux.org.uk> References: <20210526135535.2515123-1-vladimir.oltean@nxp.com> <20210526135535.2515123-4-vladimir.oltean@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210526135535.2515123-4-vladimir.oltean@nxp.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: Russell King (Oracle) Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, May 26, 2021 at 04:55:24PM +0300, Vladimir Oltean wrote: > - const struct sja1105_regs *regs = priv->info->regs; > + u64 addr = (mmd << 16) | pcs_reg; What is the reason for using "u64" here. pcs_reg is 16-bits, and mmd is five bits, which is well below 32 bits. So, why not u32? -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!