From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6AB0C47089 for ; Thu, 27 May 2021 18:56:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 914DE610C7 for ; Thu, 27 May 2021 18:56:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236208AbhE0S6Y (ORCPT ); Thu, 27 May 2021 14:58:24 -0400 Received: from mail.kernel.org ([198.145.29.99]:60020 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236061AbhE0S6L (ORCPT ); Thu, 27 May 2021 14:58:11 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 7C5F3611C9; Thu, 27 May 2021 18:56:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1622141797; bh=47XmjZ9lIAGJGFHkUS4jO8otskT8KMwjqhqghWzDZSA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=RfMY6iPcUVKUdyO5B2pfbWZ47uwXIrfym8b0C9XKET591t228aNULlZkq6YP1obkc 2tqj3maR8UjCl1JGRV/VYv0qSjxeFOo7TJssyzQ/wrVhkr/u7eiq5oYAPQM2wMPbS8 ZSAIUGEOBsK5gV4cSWS1rZ8oVJXQ0jwC0GiVzt+Fs8N2WZCRlJiCqdDAluHkjYHyKe PSGHGv4HDpK8NsSFzaritcSOXqZ/G96iUEtu7I7XAALrLAdhH5s2MwaMbmmW0mL0bm S642VPki5+RziVCCCce6fqH2YKlqzs2cmqsYyJwZ5oyEfi/IfobwxcWfTDP97H4/qF f2FWnQH4trTzg== From: Saeed Mahameed To: "David S. Miller" , Jakub Kicinski Cc: netdev@vger.kernel.org, Tariq Toukan , Saeed Mahameed Subject: [net-next V2 06/15] net/mlx5e: RX, Remove unnecessary check in RX CQE compression handling Date: Thu, 27 May 2021 11:56:15 -0700 Message-Id: <20210527185624.694304-7-saeed@kernel.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210527185624.694304-1-saeed@kernel.org> References: <20210527185624.694304-1-saeed@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Tariq Toukan There are two reasons for exiting mlx5e_decompress_cqes_cont(): 1. The compression session is completed (cqd.left == 0). 2. The budget is exhausted (work_done == budget). If after calling mlx5e_decompress_cqes_cont() we have cqd.left > 0, it necessarily implies that budget is exhausted. The first part of the complex condition is covered by the second, hence we remove it here. Signed-off-by: Tariq Toukan Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en_rx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_rx.c b/drivers/net/ethernet/mellanox/mlx5/core/en_rx.c index 5346271974f5..e88429356018 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_rx.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_rx.c @@ -1560,7 +1560,7 @@ int mlx5e_poll_rx_cq(struct mlx5e_cq *cq, int budget) if (rq->cqd.left) { work_done += mlx5e_decompress_cqes_cont(rq, cqwq, 0, budget); - if (rq->cqd.left || work_done >= budget) + if (work_done >= budget) goto out; } -- 2.31.1