From: Jesper Dangaard Brouer <brouer@redhat.com>
To: Lorenzo Bianconi <lorenzo@kernel.org>
Cc: netdev@vger.kernel.org, davem@davemloft.net, kuba@kernel.org,
brouer@redhat.com
Subject: Re: [PATCH net-next] samples: pktgen: add UDP tx checksum support
Date: Fri, 28 May 2021 14:31:49 +0200 [thread overview]
Message-ID: <20210528143149.59e5543a@carbon> (raw)
In-Reply-To: <d8476fd6ca67441dde0f2bf2618401ef91de2867.1622200776.git.lorenzo@kernel.org>
On Fri, 28 May 2021 13:22:21 +0200
Lorenzo Bianconi <lorenzo@kernel.org> wrote:
> Introduce k parameter in pktgen samples in order to toggle UDP tx
> checksum
>
> Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> ---
If you fix whitespace nits below:
Acked-by: Jesper Dangaard Brouer <brouer@redhat.com>
> samples/pktgen/parameters.sh | 7 ++++++-
> samples/pktgen/pktgen_sample01_simple.sh | 2 ++
> samples/pktgen/pktgen_sample02_multiqueue.sh | 2 ++
> samples/pktgen/pktgen_sample03_burst_single_flow.sh | 2 ++
> samples/pktgen/pktgen_sample04_many_flows.sh | 2 ++
> samples/pktgen/pktgen_sample05_flow_per_thread.sh | 2 ++
> .../pktgen_sample06_numa_awared_queue_irq_affinity.sh | 2 ++
> 7 files changed, 18 insertions(+), 1 deletion(-)
>
> diff --git a/samples/pktgen/parameters.sh b/samples/pktgen/parameters.sh
> index b4c1b371e4b8..7a425fc260ee 100644
> --- a/samples/pktgen/parameters.sh
> +++ b/samples/pktgen/parameters.sh
[...]
> @@ -88,6 +89,10 @@ while getopts "s:i:d:m:p:f:t:c:n:b:w:vxh6a" option; do
> export APPEND=yes
> info "Append mode: APPEND=$APPEND"
> ;;
> + k)
> + export UDP_CSUM=yes
> + info "UDP tx checksum: UDP_CSUM=$UDP_CSUM"
> + ;;
You whitespaces are off here... could you just use the existing (shell)
code use of whitespaces? (else it looks silly when viewing with
different editors, you vim likely hides this looks off).
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
prev parent reply other threads:[~2021-05-28 12:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-28 11:22 [PATCH net-next] samples: pktgen: add UDP tx checksum support Lorenzo Bianconi
2021-05-28 12:31 ` Jesper Dangaard Brouer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210528143149.59e5543a@carbon \
--to=brouer@redhat.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=lorenzo@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).