* [PATCH net-next] samples: pktgen: add UDP tx checksum support
@ 2021-05-28 11:22 Lorenzo Bianconi
2021-05-28 12:31 ` Jesper Dangaard Brouer
0 siblings, 1 reply; 2+ messages in thread
From: Lorenzo Bianconi @ 2021-05-28 11:22 UTC (permalink / raw)
To: netdev; +Cc: davem, kuba, brouer
Introduce k parameter in pktgen samples in order to toggle UDP tx
checksum
Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
---
samples/pktgen/parameters.sh | 7 ++++++-
samples/pktgen/pktgen_sample01_simple.sh | 2 ++
samples/pktgen/pktgen_sample02_multiqueue.sh | 2 ++
samples/pktgen/pktgen_sample03_burst_single_flow.sh | 2 ++
samples/pktgen/pktgen_sample04_many_flows.sh | 2 ++
samples/pktgen/pktgen_sample05_flow_per_thread.sh | 2 ++
.../pktgen_sample06_numa_awared_queue_irq_affinity.sh | 2 ++
7 files changed, 18 insertions(+), 1 deletion(-)
diff --git a/samples/pktgen/parameters.sh b/samples/pktgen/parameters.sh
index b4c1b371e4b8..7a425fc260ee 100644
--- a/samples/pktgen/parameters.sh
+++ b/samples/pktgen/parameters.sh
@@ -11,6 +11,7 @@ function usage() {
echo " -d : (\$DEST_IP) destination IP. CIDR (e.g. 198.18.0.0/15) is also allowed"
echo " -m : (\$DST_MAC) destination MAC-addr"
echo " -p : (\$DST_PORT) destination PORT range (e.g. 433-444) is also allowed"
+ echo " -k : (\$UDP_CSUM) enable UDP tx checksum"
echo " -t : (\$THREADS) threads to start"
echo " -f : (\$F_THREAD) index of first thread (zero indexed CPU number)"
echo " -c : (\$SKB_CLONE) SKB clones send before alloc new SKB"
@@ -26,7 +27,7 @@ function usage() {
## --- Parse command line arguments / parameters ---
## echo "Commandline options:"
-while getopts "s:i:d:m:p:f:t:c:n:b:w:vxh6a" option; do
+while getopts "s:i:d:m:p:f:t:c:n:b:w:vxh6ak" option; do
case $option in
i) # interface
export DEV=$OPTARG
@@ -88,6 +89,10 @@ while getopts "s:i:d:m:p:f:t:c:n:b:w:vxh6a" option; do
export APPEND=yes
info "Append mode: APPEND=$APPEND"
;;
+ k)
+ export UDP_CSUM=yes
+ info "UDP tx checksum: UDP_CSUM=$UDP_CSUM"
+ ;;
h|?|*)
usage;
err 2 "[ERROR] Unknown parameters!!!"
diff --git a/samples/pktgen/pktgen_sample01_simple.sh b/samples/pktgen/pktgen_sample01_simple.sh
index a09f3422fbcc..246cfe02bb82 100755
--- a/samples/pktgen/pktgen_sample01_simple.sh
+++ b/samples/pktgen/pktgen_sample01_simple.sh
@@ -72,6 +72,8 @@ if [ -n "$DST_PORT" ]; then
pg_set $DEV "udp_dst_max $UDP_DST_MAX"
fi
+[ ! -z "$UDP_CSUM" ] && pg_set $dev "flag UDPCSUM"
+
# Setup random UDP port src range
pg_set $DEV "flag UDPSRC_RND"
pg_set $DEV "udp_src_min $UDP_SRC_MIN"
diff --git a/samples/pktgen/pktgen_sample02_multiqueue.sh b/samples/pktgen/pktgen_sample02_multiqueue.sh
index acae8ede0d6c..c6af3d9d5171 100755
--- a/samples/pktgen/pktgen_sample02_multiqueue.sh
+++ b/samples/pktgen/pktgen_sample02_multiqueue.sh
@@ -75,6 +75,8 @@ for ((thread = $F_THREAD; thread <= $L_THREAD; thread++)); do
pg_set $dev "udp_dst_max $UDP_DST_MAX"
fi
+ [ ! -z "$UDP_CSUM" ] && pg_set $dev "flag UDPCSUM"
+
# Setup random UDP port src range
pg_set $dev "flag UDPSRC_RND"
pg_set $dev "udp_src_min $UDP_SRC_MIN"
diff --git a/samples/pktgen/pktgen_sample03_burst_single_flow.sh b/samples/pktgen/pktgen_sample03_burst_single_flow.sh
index 5adcf954de73..ab87de440277 100755
--- a/samples/pktgen/pktgen_sample03_burst_single_flow.sh
+++ b/samples/pktgen/pktgen_sample03_burst_single_flow.sh
@@ -73,6 +73,8 @@ for ((thread = $F_THREAD; thread <= $L_THREAD; thread++)); do
pg_set $dev "udp_dst_max $UDP_DST_MAX"
fi
+ [ ! -z "$UDP_CSUM" ] && pg_set $dev "flag UDPCSUM"
+
# Setup burst, for easy testing -b 0 disable bursting
# (internally in pktgen default and minimum burst=1)
if [[ ${BURST} -ne 0 ]]; then
diff --git a/samples/pktgen/pktgen_sample04_many_flows.sh b/samples/pktgen/pktgen_sample04_many_flows.sh
index ddce876635aa..56c5f5af350f 100755
--- a/samples/pktgen/pktgen_sample04_many_flows.sh
+++ b/samples/pktgen/pktgen_sample04_many_flows.sh
@@ -72,6 +72,8 @@ for ((thread = $F_THREAD; thread <= $L_THREAD; thread++)); do
pg_set $dev "udp_dst_max $UDP_DST_MAX"
fi
+ [ ! -z "$UDP_CSUM" ] && pg_set $dev "flag UDPCSUM"
+
# Randomize source IP-addresses
pg_set $dev "flag IPSRC_RND"
pg_set $dev "src_min $SRC_MIN"
diff --git a/samples/pktgen/pktgen_sample05_flow_per_thread.sh b/samples/pktgen/pktgen_sample05_flow_per_thread.sh
index 4a65fe2fcee9..6e0effabca59 100755
--- a/samples/pktgen/pktgen_sample05_flow_per_thread.sh
+++ b/samples/pktgen/pktgen_sample05_flow_per_thread.sh
@@ -62,6 +62,8 @@ for ((thread = $F_THREAD; thread <= $L_THREAD; thread++)); do
pg_set $dev "udp_dst_max $UDP_DST_MAX"
fi
+ [ ! -z "$UDP_CSUM" ] && pg_set $dev "flag UDPCSUM"
+
# Setup source IP-addresses based on thread number
pg_set $dev "src_min 198.18.$((thread+1)).1"
pg_set $dev "src_max 198.18.$((thread+1)).1"
diff --git a/samples/pktgen/pktgen_sample06_numa_awared_queue_irq_affinity.sh b/samples/pktgen/pktgen_sample06_numa_awared_queue_irq_affinity.sh
index 10f1da571f40..7c27923083a6 100755
--- a/samples/pktgen/pktgen_sample06_numa_awared_queue_irq_affinity.sh
+++ b/samples/pktgen/pktgen_sample06_numa_awared_queue_irq_affinity.sh
@@ -92,6 +92,8 @@ for ((i = 0; i < $THREADS; i++)); do
pg_set $dev "udp_dst_max $UDP_DST_MAX"
fi
+ [ ! -z "$UDP_CSUM" ] && pg_set $dev "flag UDPCSUM"
+
# Setup random UDP port src range
pg_set $dev "flag UDPSRC_RND"
pg_set $dev "udp_src_min $UDP_SRC_MIN"
--
2.31.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] samples: pktgen: add UDP tx checksum support
2021-05-28 11:22 [PATCH net-next] samples: pktgen: add UDP tx checksum support Lorenzo Bianconi
@ 2021-05-28 12:31 ` Jesper Dangaard Brouer
0 siblings, 0 replies; 2+ messages in thread
From: Jesper Dangaard Brouer @ 2021-05-28 12:31 UTC (permalink / raw)
To: Lorenzo Bianconi; +Cc: netdev, davem, kuba, brouer
On Fri, 28 May 2021 13:22:21 +0200
Lorenzo Bianconi <lorenzo@kernel.org> wrote:
> Introduce k parameter in pktgen samples in order to toggle UDP tx
> checksum
>
> Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> ---
If you fix whitespace nits below:
Acked-by: Jesper Dangaard Brouer <brouer@redhat.com>
> samples/pktgen/parameters.sh | 7 ++++++-
> samples/pktgen/pktgen_sample01_simple.sh | 2 ++
> samples/pktgen/pktgen_sample02_multiqueue.sh | 2 ++
> samples/pktgen/pktgen_sample03_burst_single_flow.sh | 2 ++
> samples/pktgen/pktgen_sample04_many_flows.sh | 2 ++
> samples/pktgen/pktgen_sample05_flow_per_thread.sh | 2 ++
> .../pktgen_sample06_numa_awared_queue_irq_affinity.sh | 2 ++
> 7 files changed, 18 insertions(+), 1 deletion(-)
>
> diff --git a/samples/pktgen/parameters.sh b/samples/pktgen/parameters.sh
> index b4c1b371e4b8..7a425fc260ee 100644
> --- a/samples/pktgen/parameters.sh
> +++ b/samples/pktgen/parameters.sh
[...]
> @@ -88,6 +89,10 @@ while getopts "s:i:d:m:p:f:t:c:n:b:w:vxh6a" option; do
> export APPEND=yes
> info "Append mode: APPEND=$APPEND"
> ;;
> + k)
> + export UDP_CSUM=yes
> + info "UDP tx checksum: UDP_CSUM=$UDP_CSUM"
> + ;;
You whitespaces are off here... could you just use the existing (shell)
code use of whitespaces? (else it looks silly when viewing with
different editors, you vim likely hides this looks off).
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-05-28 12:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-05-28 11:22 [PATCH net-next] samples: pktgen: add UDP tx checksum support Lorenzo Bianconi
2021-05-28 12:31 ` Jesper Dangaard Brouer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).