From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFB82C47092 for ; Mon, 31 May 2021 02:42:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 93BCA6052B for ; Mon, 31 May 2021 02:42:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230013AbhEaCoX (ORCPT ); Sun, 30 May 2021 22:44:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55934 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229963AbhEaCoU (ORCPT ); Sun, 30 May 2021 22:44:20 -0400 Received: from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com [IPv6:2607:f8b0:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 98D00C061574 for ; Sun, 30 May 2021 19:42:40 -0700 (PDT) Received: by mail-pl1-x62c.google.com with SMTP id x10so3557646plg.3 for ; Sun, 30 May 2021 19:42:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=nSSyopAtkodXam0rk9bPy9dMoXqKVHlq6okLtwZw0Ko=; b=VhnGr1hnnxURoldGBuaG627dwczbinEqsmNgavaj5a3T50KqHg27UtpM6+al41teks KMUBN7/EqC5gSCy55ReAnH+4XMmY67r5hlEXr4Kn1K42fNW5gdhND42K7sxhipFW8wal JFw7XepdheyPhg35JjoXzab/yhvL/VFW0x8Nip7ntLToaDoCFwDw7exhDaHm0XXDFKlQ 2Ozlu9lTjzHoHZgYoXfN5xVhM90Sc85oixvwoKDZz5PtPS87Gu63I83Rl3tJNZfgAppC 1Fi/UuSBwxDSfR6TxdFnAgGseP31an1dFA+W/LldpWUUG7Z7dLy2jtYz70LWNNv+NjdM +yDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=nSSyopAtkodXam0rk9bPy9dMoXqKVHlq6okLtwZw0Ko=; b=p+2PY3D2qCaCKWng/TXewpGKiPQiyGVagz09VROyyVjPIJ8YmgySNQjYxx+iPKO+Qq ZneFp4Ob49lqrvhDV9xqxin9fvt+FDqpCUVqQTKhxHqSSdhvJcdv6no1OkjU1MjFomtG 0kRGCdcD0C+S6ds/WgWKt1cTpgJpZpY4imrrxQjkHiHT1ZZPLxoiIU/Mx1B/RKDkEC5Z zWmSypMH/+xegE5u22SVjx079CIPtatjxga4zg3WfQNgzt/q5fuiBNhtdO0/Pb0crGfp xsZ/dyPeRrLwnn3yPb66wUsNo1SZXeHVcO0bws1p+CWr6zi680gB0A++WQre6iduOlnK cEsg== X-Gm-Message-State: AOAM532H3bNiVAewLXM8OJue6CqIz6ckFdeq6c8aDaiP2WKCNW852ERl 6hVqSlQuaB6WeVtFFM0RFZTu2A== X-Google-Smtp-Source: ABdhPJzF45oicpEILtAMZcOUpf2b1haXW7u9IJl6+y4tlW5sNxjuc6gnffkqsFOS2//pGv6h/GVlVA== X-Received: by 2002:a17:902:e812:b029:ee:ff2f:da28 with SMTP id u18-20020a170902e812b02900eeff2fda28mr18153025plg.15.1622428959880; Sun, 30 May 2021 19:42:39 -0700 (PDT) Received: from hermes.local (76-14-218-44.or.wavecable.com. [76.14.218.44]) by smtp.gmail.com with ESMTPSA id i14sm9354564pfk.130.2021.05.30.19.42.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 30 May 2021 19:42:39 -0700 (PDT) Date: Sun, 30 May 2021 19:42:34 -0700 From: Stephen Hemminger To: Hongren Zheng Cc: Daniel Borkmann , David Ahern , netdev@vger.kernel.org Subject: Re: [RFC] add extack errors for iptoken Message-ID: <20210530194234.2fd8b269@hermes.local> In-Reply-To: References: <20210331204902.78d87b40@hermes.local> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sat, 29 May 2021 14:31:56 +0800 Hongren Zheng wrote: > On Wed, Apr 28, 2021 at 08:55:08PM +0800, Hongren Zheng wrote: > > > Perhaps the following (NOT TESTED) kernel patch will show you how such error messages > > > could be added. > > > > Since this patch has been tested, and we have waited a long time for > > comments and there is no further response, I wonder if it is the time > > to submit this patch to the kernel. > > Is there any updates? > > I'm not quite familiar with "RFC" procedure. Should I send this patch to > netdev mailing list with title "[PATCH] add extack errors for iptoken" now > (I suppose not), or wait for Stephen Hemminger sending it, or wait for > more comments? > The kernel changes is already upstream with this commit for 5.12 kernel commit 3583a4e8d77d44697a21437227dd53fc6e7b2cb5 Author: Stephen Hemminger Date: Wed Apr 7 08:59:12 2021 -0700 ipv6: report errors for iftoken via netlink extack Setting iftoken can fail for several different reasons but there and there was no report to user as to the cause. Add netlink extended errors to the processing of the request. This requires adding additional argument through rtnl_af_ops set_link_af callback. Reported-by: Hongren Zheng Signed-off-by: Stephen Hemminger Reviewed-by: David Ahern Signed-off-by: David S. Miller