From: "Marek Behún" <kabel@kernel.org>
To: linux-leds@vger.kernel.org
Cc: netdev@vger.kernel.org, Pavel Machek <pavel@ucw.cz>,
Russell King <linux@armlinux.org.uk>,
Andrew Lunn <andrew@lunn.ch>,
Matthias Schiffer <matthias.schiffer@ew.tq-group.com>,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Subject: Re: [PATCH leds v2 10/10] leds: turris-omnia: support offloading netdev trigger for WAN LED
Date: Tue, 1 Jun 2021 03:44:30 +0200 [thread overview]
Message-ID: <20210601034430.0b69c05e@thinkpad> (raw)
In-Reply-To: <20210601005155.27997-11-kabel@kernel.org>
> +static int omnia_led_trig_offload_off(struct omnia_leds *leds,
> + struct omnia_led *led)
> +{
> + int ret;
> +
> + if (!led->phydev)
> + return 0;
> +
> + mutex_lock(&leds->lock);
> +
> + /* set PHY's LED[0] pin to default values */
> + ret = phy_modify_paged(led->phydev, MII_MARVELL_LED_PAGE,
> + MII_PHY_LED_TCR,
> + MII_PHY_LED_TCR_PULSESTR_MASK |
> + MII_PHY_LED_TCR_BLINKRATE_MASK,
> + (4 << MII_PHY_LED_TCR_PULSESTR_SHIFT) |
> + (1 << MII_PHY_LED_TCR_BLINKRATE_SHIFT));
> +
> + ret = phy_modify_paged(led->phydev, MII_MARVELL_LED_PAGE,
> + MII_PHY_LED_CTRL, 0xf, 0xe);
> +
I forgot to add warnings here if ret < 0, since offload disabling must
return 0.
next prev parent reply other threads:[~2021-06-01 1:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-01 0:51 [PATCH leds v2 00/10] Add support for offloading netdev trigger to HW + example implementation for Turris Omnia Marek Behún
2021-06-01 0:51 ` [PATCH leds v2 01/10] leds: trigger: netdev: don't explicitly zero kzalloced data Marek Behún
2021-06-01 0:51 ` [PATCH leds v2 02/10] leds: trigger: add API for HW offloading of triggers Marek Behún
2021-06-01 0:51 ` [PATCH leds v2 03/10] leds: trigger: netdev: move trigger data structure to global include dir Marek Behún
2021-06-01 0:51 ` [PATCH leds v2 04/10] leds: trigger: netdev: support HW offloading Marek Behún
2021-06-01 0:51 ` [PATCH leds v2 05/10] leds: trigger: netdev: change spinlock to mutex Marek Behún
2021-06-01 0:51 ` [PATCH leds v2 06/10] leds: core: inform trigger that it's deactivation is due to LED removal Marek Behún
2021-06-01 21:12 ` Andrew Lunn
2021-06-02 12:44 ` Marek Behún
2021-06-01 0:51 ` [PATCH leds v2 07/10] leds: turris-omnia: refactor sw mode setting code into separate function Marek Behún
2021-06-01 0:51 ` [PATCH leds v2 08/10] leds: turris-omnia: refactor brightness setting function Marek Behún
2021-06-01 0:51 ` [PATCH leds v2 09/10] leds: turris-omnia: initialize each multicolor LED to white color Marek Behún
2021-06-01 0:51 ` [PATCH leds v2 10/10] leds: turris-omnia: support offloading netdev trigger for WAN LED Marek Behún
2021-06-01 1:44 ` Marek Behún [this message]
2021-06-01 21:19 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210601034430.0b69c05e@thinkpad \
--to=kabel@kernel.org \
--cc=andrew@lunn.ch \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-leds@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=matthias.schiffer@ew.tq-group.com \
--cc=mchehab+huawei@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).