From: Jesse Brandeburg <jesse.brandeburg@intel.com>
To: Huazhong Tan <tanhuazhong@huawei.com>
Cc: <davem@davemloft.net>, <kuba@kernel.org>,
<netdev@vger.kernel.org>, <salil.mehta@huawei.com>,
<yisen.zhuang@huawei.com>, <huangdaode@huawei.com>,
<linuxarm@huawei.com>, <dledford@redhat.com>, <jgg@ziepe.ca>,
<netanel@amazon.com>, <akiyano@amazon.com>,
<thomas.lendacky@amd.com>, <irusskikh@marvell.com>,
<michael.chan@broadcom.com>, <edwin.peer@broadcom.com>,
<rohitm@chelsio.com>, <jacob.e.keller@intel.com>,
<ioana.ciornei@nxp.com>, <vladimir.oltean@nxp.com>,
<sgoutham@marvell.com>, <sbhatta@marvell.com>,
<saeedm@nvidia.com>, <ecree.xilinx@gmail.com>,
<grygorii.strashko@ti.com>, <merez@codeaurora.org>,
<kvalo@codeaurora.org>, <linux-wireless@vger.kernel.org>
Subject: Re: [RFC V2 net-next 0/3] ethtool: extend coalesce uAPI
Date: Tue, 1 Jun 2021 11:14:36 -0700 [thread overview]
Message-ID: <20210601111436.00001c69@intel.com> (raw)
In-Reply-To: <1622258536-55776-1-git-send-email-tanhuazhong@huawei.com>
Huazhong Tan wrote:
> In order to support some configuration in coalesce uAPI, this RFC
> extends coalesce uAPI and add support for CQE mode.
> ...
> 3. ethool(netlink with cqe mode) + kernel with cqe mode:
> estuary:/$ ethtool -c eth0
> Coalesce parameters for eth0:
> Adaptive RX: on TX: on
> stats-block-usecs: n/a
> sample-interval: n/a
> pkt-rate-low: n/a
> pkt-rate-high: n/a
>
> rx-usecs: 20
> rx-frames: 0
> rx-usecs-irq: n/a
> rx-frames-irq: n/a
>
> tx-usecs: 20
> tx-frames: 0
> tx-usecs-irq: n/a
> tx-frames-irq: n/a
>
> rx-usecs-low: n/a
> rx-frame-low: n/a
> tx-usecs-low: n/a
> tx-frame-low: n/a
>
> rx-usecs-high: 0
> rx-frame-high: n/a
> tx-usecs-high: 0
> tx-frame-high: n/a
>
> CQE mode RX: off TX: off
BTW, thanks for working on something like this.
I hope it's not just me, but I don't like the display of the new CQE
line, at the very least, it's not consistent with what is there already
in the output of this command, and at worst, it surprises the user and
makes it hard to parse for any scripting tools.
Can I suggest something like:
rx-cqe: off
tx-cqe: off
rx-eqe: off
tx-eqe: off
Then, if hardware is in EQE mode it is clear that it's supported and
ON/OFF, as well as for CQE mode.
-Jesse
next prev parent reply other threads:[~2021-06-01 18:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-29 3:22 [RFC V2 net-next 0/3] ethtool: extend coalesce uAPI Huazhong Tan
2021-05-29 3:22 ` [RFC V2 net-next 1/3] ethtool: extend coalesce setting uAPI with CQE mode Huazhong Tan
2021-05-29 21:23 ` Jakub Kicinski
2021-05-31 1:24 ` Huazhong Tan
2021-06-01 5:09 ` Jakub Kicinski
2021-05-29 3:22 ` [RFC V2 net-next 2/3] net: hns3: add support for EQE/CQE mode configuration Huazhong Tan
2021-05-29 3:22 ` [RFC V2 net-next 3/3] net: hns3: add ethtool support for CQE/EQE " Huazhong Tan
2021-06-01 18:14 ` Jesse Brandeburg [this message]
2021-06-01 20:29 ` [RFC V2 net-next 0/3] ethtool: extend coalesce uAPI Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210601111436.00001c69@intel.com \
--to=jesse.brandeburg@intel.com \
--cc=akiyano@amazon.com \
--cc=davem@davemloft.net \
--cc=dledford@redhat.com \
--cc=ecree.xilinx@gmail.com \
--cc=edwin.peer@broadcom.com \
--cc=grygorii.strashko@ti.com \
--cc=huangdaode@huawei.com \
--cc=ioana.ciornei@nxp.com \
--cc=irusskikh@marvell.com \
--cc=jacob.e.keller@intel.com \
--cc=jgg@ziepe.ca \
--cc=kuba@kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=merez@codeaurora.org \
--cc=michael.chan@broadcom.com \
--cc=netanel@amazon.com \
--cc=netdev@vger.kernel.org \
--cc=rohitm@chelsio.com \
--cc=saeedm@nvidia.com \
--cc=salil.mehta@huawei.com \
--cc=sbhatta@marvell.com \
--cc=sgoutham@marvell.com \
--cc=tanhuazhong@huawei.com \
--cc=thomas.lendacky@amd.com \
--cc=vladimir.oltean@nxp.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).