From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Xu Liang <lxu@maxlinear.com>
Cc: andrew@lunn.ch, hkallweit1@gmail.com, netdev@vger.kernel.org,
davem@davemloft.net, kuba@kernel.org, hmehrtens@maxlinear.com,
tmohren@maxlinear.com
Subject: Re: [PATCH] phy: maxlinear: add Maxlinear GPY115/21x/24x driver
Date: Tue, 1 Jun 2021 13:25:00 +0100 [thread overview]
Message-ID: <20210601122459.GW30436@shell.armlinux.org.uk> (raw)
In-Reply-To: <20210601074427.40990-1-lxu@maxlinear.com>
On Tue, Jun 01, 2021 at 03:44:27PM +0800, Xu Liang wrote:
> + if (!(ret & PHY_MIISTAT_LS)
> + || FIELD_GET(PHY_MIISTAT_SPD_MASK, ret) != PHY_MIISTAT_SPD_2500)
> + return false;
We prefer the operators at the end of the previous line rather than at
the beginning of the following line. So:
+ if (!(ret & PHY_MIISTAT_LS) ||
+ FIELD_GET(PHY_MIISTAT_SPD_MASK, ret) != PHY_MIISTAT_SPD_2500)
+ return false;
Same for the other instances of this.
I think checkpatch should warn about this - did you run your patch
through checkpatch before sending? There seems to be other style issues
too (e.g. missing blank lines.)
Thanks.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2021-06-01 12:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-01 7:44 [PATCH] phy: maxlinear: add Maxlinear GPY115/21x/24x driver Xu Liang
2021-06-01 11:41 ` Wong Vee Khee
2021-06-01 14:46 ` Liang Xu
2021-06-01 12:25 ` Russell King (Oracle) [this message]
2021-06-01 12:41 ` Andrew Lunn
2021-06-01 15:53 ` Liang Xu
2021-06-01 16:55 ` Andrew Lunn
2021-06-01 17:14 ` Liang Xu
2021-06-01 19:13 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210601122459.GW30436@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=hmehrtens@maxlinear.com \
--cc=kuba@kernel.org \
--cc=lxu@maxlinear.com \
--cc=netdev@vger.kernel.org \
--cc=tmohren@maxlinear.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).