From: "Marek Behún" <kabel@kernel.org>
To: Andrew Lunn <andrew@lunn.ch>
Cc: linux-leds@vger.kernel.org, netdev@vger.kernel.org,
Pavel Machek <pavel@ucw.cz>, Dan Murphy <dmurphy@ti.com>,
Russell King <linux@armlinux.org.uk>,
Matthias Schiffer <matthias.schiffer@ew.tq-group.com>,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Subject: Re: [PATCH leds v2 06/10] leds: core: inform trigger that it's deactivation is due to LED removal
Date: Wed, 2 Jun 2021 14:44:39 +0200 [thread overview]
Message-ID: <20210602144439.4d20b295@dellmb> (raw)
In-Reply-To: <YLai2aHKKKqwRysm@lunn.ch>
On Tue, 1 Jun 2021 23:12:57 +0200
Andrew Lunn <andrew@lunn.ch> wrote:
> On Tue, Jun 01, 2021 at 02:51:51AM +0200, Marek Behún wrote:
> > Move setting of the LED_UNREGISTERING before deactivating the
> > trigger in led_classdev_unregister().
> >
> > It can be useful for a LED trigger to know whether it is being
> > deactivated due to the LED being unregistered. This makes it
> > possible for LED drivers which implement trigger offloading to
> > leave the LED in HW triggering mode when the LED is unregistered,
> > instead of disabling it.
>
> Humm, i'm not sure that is a good idea. I don't expect my Ethernet
> switch to keep forwarding frames when i unload the driver.
We want to make it so that when leds-turris-omnia driver is unloaded,
the LEDs will start blinking in HW mode as they did before the driver
was loaded. This is needed for that.
Marek
next prev parent reply other threads:[~2021-06-02 12:44 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-01 0:51 [PATCH leds v2 00/10] Add support for offloading netdev trigger to HW + example implementation for Turris Omnia Marek Behún
2021-06-01 0:51 ` [PATCH leds v2 01/10] leds: trigger: netdev: don't explicitly zero kzalloced data Marek Behún
2021-06-01 0:51 ` [PATCH leds v2 02/10] leds: trigger: add API for HW offloading of triggers Marek Behún
2021-06-01 0:51 ` [PATCH leds v2 03/10] leds: trigger: netdev: move trigger data structure to global include dir Marek Behún
2021-06-01 0:51 ` [PATCH leds v2 04/10] leds: trigger: netdev: support HW offloading Marek Behún
2021-06-01 0:51 ` [PATCH leds v2 05/10] leds: trigger: netdev: change spinlock to mutex Marek Behún
2021-06-01 0:51 ` [PATCH leds v2 06/10] leds: core: inform trigger that it's deactivation is due to LED removal Marek Behún
2021-06-01 21:12 ` Andrew Lunn
2021-06-02 12:44 ` Marek Behún [this message]
2021-06-01 0:51 ` [PATCH leds v2 07/10] leds: turris-omnia: refactor sw mode setting code into separate function Marek Behún
2021-06-01 0:51 ` [PATCH leds v2 08/10] leds: turris-omnia: refactor brightness setting function Marek Behún
2021-06-01 0:51 ` [PATCH leds v2 09/10] leds: turris-omnia: initialize each multicolor LED to white color Marek Behún
2021-06-01 0:51 ` [PATCH leds v2 10/10] leds: turris-omnia: support offloading netdev trigger for WAN LED Marek Behún
2021-06-01 1:44 ` Marek Behún
2021-06-01 21:19 ` Andrew Lunn
2025-10-16 11:43 ` [PATCH leds v2 00/10] Add support for offloading netdev trigger to HW + example implementation for Turris Omnia Lad, Prabhakar
2025-10-16 13:14 ` Andrew Lunn
2025-10-16 18:53 ` Lad, Prabhakar
2025-10-16 19:11 ` Andrew Lunn
2025-10-16 19:25 ` Lad, Prabhakar
2025-10-16 19:44 ` Andrew Lunn
2025-10-17 15:23 ` Lad, Prabhakar
2025-10-21 10:50 ` Lee Jones
2025-11-05 13:32 ` Lad, Prabhakar
2025-11-05 15:48 ` Andrew Lunn
2025-11-05 17:52 ` Lad, Prabhakar
2025-11-05 18:35 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210602144439.4d20b295@dellmb \
--to=kabel@kernel.org \
--cc=andrew@lunn.ch \
--cc=dmurphy@ti.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-leds@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=matthias.schiffer@ew.tq-group.com \
--cc=mchehab+huawei@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox