From: "dust.li" <dust.li@linux.alibaba.com>
To: Eric Dumazet <edumazet@google.com>
Cc: David Miller <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
Tony Lu <tonylu@linux.alibaba.com>,
Xuan Zhuo <xuanzhuo@linux.alibaba.com>
Subject: Re: [PATCH net-next] tcp: avoid spurious loopback retransmit
Date: Wed, 9 Jun 2021 16:45:04 +0800 [thread overview]
Message-ID: <20210609084504.GP53857@linux.alibaba.com> (raw)
In-Reply-To: <CANn89i+vBRxKFy_Bb2_tKTh1ttLanZj99UNZcmjSQ=oq4-j6og@mail.gmail.com>
On Wed, Jun 09, 2021 at 09:03:14AM +0200, Eric Dumazet wrote:
>On Wed, Jun 9, 2021 at 2:25 AM dust.li <dust.li@linux.alibaba.com> wrote:
>>
>
>> Normal RTO and fast retransmits are rarely triggerred.
>> But for TLP timers, it is easy since its timeout is usally only 2ms.
>>
>
>OK, by definition rtx timers can fire too early, so I think we will
>leave the code as it is.
>(ie not try to do special things for 'special' interfaces like loopback)
>
>We want to be generic as much as possible.
Totally understand!
After talking to you, I also rethinked this a bit more.
The original patch is bad and not generic, my original intention is
also to discuss with the community.
Through the patch is bad, I still think the problem is generic.
Devices like loopback/veth/ifb and maybe some others as well,
who depend on netif_rx() or tasklet to receive packets from CPU
backlog should all have this problem.
But I really didn't find a general way to gracefully solve this.
Thanks.
next prev parent reply other threads:[~2021-06-09 8:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-07 15:45 [PATCH net-next] tcp: avoid spurious loopback retransmit Dust Li
2021-06-07 16:17 ` Eric Dumazet
2021-06-08 3:09 ` dust.li
2021-06-08 16:04 ` Eric Dumazet
2021-06-09 0:25 ` dust.li
2021-06-09 7:03 ` Eric Dumazet
2021-06-09 8:45 ` dust.li [this message]
2021-06-09 16:46 ` Eric Dumazet
2021-06-22 8:25 ` [tcp] 7bf6f9c438: kernel-selftests.net/mptcp.mptcp_connect.sh.fail kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210609084504.GP53857@linux.alibaba.com \
--to=dust.li@linux.alibaba.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=netdev@vger.kernel.org \
--cc=tonylu@linux.alibaba.com \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).