Netdev List
 help / color / mirror / Atom feed
From: Kumar Kartikeya Dwivedi <memxor@gmail.com>
To: Andrii Nakryiko <andrii.nakryiko@gmail.com>
Cc: bpf <bpf@vger.kernel.org>, "Alexei Starovoitov" <ast@kernel.org>,
	"Daniel Borkmann" <daniel@iogearbox.net>,
	"Andrii Nakryiko" <andrii@kernel.org>,
	"Martin KaFai Lau" <kafai@fb.com>,
	"Song Liu" <songliubraving@fb.com>, "Yonghong Song" <yhs@fb.com>,
	"John Fastabend" <john.fastabend@gmail.com>,
	"KP Singh" <kpsingh@kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Jesper Dangaard Brouer" <brouer@redhat.com>,
	"Toke Høiland-Jørgensen" <toke@redhat.com>,
	"Shaun Crampton" <shaun@tigera.io>,
	Networking <netdev@vger.kernel.org>
Subject: Re: [PATCH bpf-next v7 0/3] Add TC-BPF API
Date: Sat, 12 Jun 2021 02:53:48 +0530	[thread overview]
Message-ID: <20210611212348.qnwkyvmpqar3qwjr@apollo> (raw)
In-Reply-To: <CAEf4BzZWBLYuuSY5p=TO1uj4ie+JCxZ4Js0uxUmgNBwQcwZ5+g@mail.gmail.com>

On Sat, Jun 12, 2021 at 02:28:09AM IST, Andrii Nakryiko wrote:
> On Fri, Jun 11, 2021 at 1:47 PM Kumar Kartikeya Dwivedi
> <memxor@gmail.com> wrote:
> >
> > On Sat, Jun 12, 2021 at 01:31:56AM IST, Andrii Nakryiko wrote:
> > > On Wed, May 12, 2021 at 3:35 AM Kumar Kartikeya Dwivedi
> > > <memxor@gmail.com> wrote:
> > > >
> > > > This is the seventh version of the TC-BPF series.
> > > >
> > > > It adds a simple API that uses netlink to attach the tc filter and its bpf
> > > > classifier program. Currently, a user needs to shell out to the tc command line
> > > > to be able to create filters and attach SCHED_CLS programs as classifiers. With
> > > > the help of this API, it will be possible to use libbpf for doing all parts of
> > > > bpf program setup and attach.
> > > >
> > > > Changelog contains details of patchset evolution.
> > > >
> > > > In an effort to keep discussion focused, this series doesn't have the high level
> > > > TC-BPF API. It was clear that there is a need for a bpf_link API in the kernel,
> > > > hence that will be submitted as a separate patchset based on this.
> > > >
> > > > The individual commit messages contain more details, and also a brief summary of
> > > > the API.
> > > >
> > > > Changelog:
> > > > ----------
> > >
> > > Hey Kartikeya,
> > >
> > > There were few issues flagged by Coverity after I synced libbpf to
> > > Github. A bunch of them are netlink.c-related. Could you please take a
> > > look and see if they are false positives or something that we can
> > > actually fix? See links to the issues below. Thanks!
> > >
> > >   [0] https://scan3.coverity.com/reports.htm#v40547/p11903/fileInstanceId=53874109&defectInstanceId=10901199&mergedDefectId=141815
> > >   [1] https://scan3.coverity.com/reports.htm#v40547/p11903/fileInstanceId=53874109&defectInstanceId=10901193&mergedDefectId=322806
> > >   [2] https://scan3.coverity.com/reports.htm#v40547/p11903/fileInstanceId=53874109&defectInstanceId=10901197&mergedDefectId=322807
> > >   [3] https://scan3.coverity.com/reports.htm#v40547/p11903/fileInstanceId=53874109&defectInstanceId=10901195&mergedDefectId=322808
> > >
> >
> > Hi Andrii,
> >
> > These links don't work for me (I get a timeout). Would you know why? Is there
> > some other link where I can look at them?
> >
>
> Sorry, I don't know any other way to share them.
> https://scan3.coverity.com/reports.htm#v40547/p11903 should show all
> libbpf issues. Maybe try creating an account with coverity.com?..
>

Thanks, that helped. I now see 401 Unauthorized, so I sent an approval request.

--
Kartikeya

  reply	other threads:[~2021-06-11 21:25 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-12 10:34 [PATCH bpf-next v7 0/3] Add TC-BPF API Kumar Kartikeya Dwivedi
2021-05-12 10:34 ` [PATCH bpf-next v7 1/3] libbpf: add netlink helpers Kumar Kartikeya Dwivedi
2021-05-12 10:34 ` [PATCH bpf-next v7 2/3] libbpf: add low level TC-BPF API Kumar Kartikeya Dwivedi
2021-05-12 10:34 ` [PATCH bpf-next v7 3/3] libbpf: add selftests for " Kumar Kartikeya Dwivedi
2021-05-17 17:54 ` [PATCH bpf-next v7 0/3] Add " Daniel Borkmann
2021-06-11 20:01 ` Andrii Nakryiko
2021-06-11 20:46   ` Kumar Kartikeya Dwivedi
2021-06-11 20:58     ` Andrii Nakryiko
2021-06-11 21:23       ` Kumar Kartikeya Dwivedi [this message]
2021-06-11 21:56         ` Andrii Nakryiko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210611212348.qnwkyvmpqar3qwjr@apollo \
    --to=memxor@gmail.com \
    --cc=andrii.nakryiko@gmail.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=brouer@redhat.com \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=john.fastabend@gmail.com \
    --cc=kafai@fb.com \
    --cc=kpsingh@kernel.org \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=shaun@tigera.io \
    --cc=songliubraving@fb.com \
    --cc=toke@redhat.com \
    --cc=yhs@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox