From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEF73C2B9F4 for ; Mon, 14 Jun 2021 12:51:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B0CF4613EF for ; Mon, 14 Jun 2021 12:51:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234113AbhFNMxw (ORCPT ); Mon, 14 Jun 2021 08:53:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34352 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233871AbhFNMxY (ORCPT ); Mon, 14 Jun 2021 08:53:24 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5153DC06124A for ; Mon, 14 Jun 2021 05:51:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=jJHQnMopesoro5jl8icgxY4BHRWOXCYDaKDIK4qKZWQ=; b=F+UEFZTuZdRqqBSDxliDelUsR 98NcW2Ep21/cqHAb81I/flRKSWur07N17YvIR+fg65jy+x0UWU6QuI0NrOvnhRWo0+zIHEZN9Kh+R z361JmQQ9PhLlTbFJUhuI4wAXH2E8nH3iejUON+hYrQ0DtUk9yXZ1q7vEbzqv16Kpb0IvdeYOFs/z KdZYY284pFl3hnI8qyJwZebK8ULVFRf1v2mW9I5Lmxve61uZjonIG/dKTn08w1cBC82XdYWDvzs6m E4H2PTBIXuFifhIHoIxtOrFK933Pvh7c7Fkjd0Ql6bauWrqTh+dNlDioMXKKza3ZQGEvD2SlKO/I0 5za+O7Kdw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:45004) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lsm3Z-0004HO-Az; Mon, 14 Jun 2021 13:51:09 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1lsm3Z-00048Q-1F; Mon, 14 Jun 2021 13:51:09 +0100 Date: Mon, 14 Jun 2021 13:51:09 +0100 From: "Russell King (Oracle)" To: Vladimir Oltean Cc: Jakub Kicinski , "David S. Miller" , netdev@vger.kernel.org, Florian Fainelli , Andrew Lunn , Heiner Kallweit , Radu Pirea , Vladimir Oltean Subject: Re: [PATCH v2 net-next 3/3] net: phy: nxp-c45-tja11xx: enable MDIO write access to the master/slave registers Message-ID: <20210614125108.GT22278@shell.armlinux.org.uk> References: <20210614123815.443467-1-olteanv@gmail.com> <20210614123815.443467-4-olteanv@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210614123815.443467-4-olteanv@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: Russell King (Oracle) Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Jun 14, 2021 at 03:38:15PM +0300, Vladimir Oltean wrote: > From: Vladimir Oltean > > The SJA1110 switch integrates TJA1103 PHYs, but in SJA1110 switch rev B > silicon, there is a bug in that the registers for selecting the 100base-T1 > autoneg master/slave roles are not writable. > > To enable write access to the master/slave registers, these additional > PHY writes are necessary during initialization. > > The issue has been corrected in later SJA1110 silicon versions and is > not present in the standalone PHY variants, but applying the workaround > unconditionally in the driver should not do any harm. > > Suggested-by: Radu Pirea (NXP OSS) > Signed-off-by: Vladimir Oltean Reviewed-by: Russell King (Oracle) -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!