From: Stephen Hemminger <stephen@networkplumber.org>
To: "Asbjørn Sloth Tønnesen" <asbjorn@asbjorn.st>
Cc: netdev@vger.kernel.org, Jiri Pirko <jiri@nvidia.com>
Subject: Re: [PATCH iproute2] tc: pedit: add decrement operation
Date: Mon, 14 Jun 2021 14:25:40 -0700 [thread overview]
Message-ID: <20210614142540.37eded6f@hermes.local> (raw)
In-Reply-To: <20210614203324.236756-1-asbjorn@asbjorn.st>
On Mon, 14 Jun 2021 20:33:24 +0000
Asbjørn Sloth Tønnesen <asbjorn@asbjorn.st> wrote:
> @@ -422,16 +434,21 @@ int parse_cmd(int *argc_p, char ***argv_p, __u32 len, int type, __u32 retain,
> goto done;
> }
>
> return -1;
> +
Please no unnecessary whitespace changes.
Also you are missing to print_pedit() to print the resulting change.
next prev parent reply other threads:[~2021-06-14 21:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-14 20:33 [PATCH iproute2] tc: pedit: add decrement operation Asbjørn Sloth Tønnesen
2021-06-14 21:25 ` Stephen Hemminger [this message]
2021-06-14 22:47 ` Asbjørn Sloth Tønnesen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210614142540.37eded6f@hermes.local \
--to=stephen@networkplumber.org \
--cc=asbjorn@asbjorn.st \
--cc=jiri@nvidia.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox