From: Stephen Hemminger <stephen@networkplumber.org>
To: Anton Danilov <littlesmilingcloud@gmail.com>
Cc: netdev@vger.kernel.org
Subject: Re: [RFC 2/3] [RFC iproute2-next] tc: f_u32: Fix the ipv6 pretty printing.
Date: Mon, 14 Jun 2021 19:57:00 -0700 [thread overview]
Message-ID: <20210614195700.260c8933@hermes.local> (raw)
In-Reply-To: <20210608153309.4019-2-littlesmilingcloud@gmail.com>
On Tue, 8 Jun 2021 18:33:08 +0300
Anton Danilov <littlesmilingcloud@gmail.com> wrote:
> - fprintf(f, "\n match IP protocol %d",
> + return fprintf(f, "\n match IP protocol %d",
> ntohl(key->val) >> 16);
Ok, but better yet, upgrade f_u32 to do proper JSON output.
> + // The ipv6 pretty printing requires an additional call at the end.
> + // Call the show_keys with the NULL value after call with last key.
> + for (i = 0; i <= sel->nkeys; i++) {
iproute2 uses kernel style C so no C++ style comments please
next prev parent reply other threads:[~2021-06-15 2:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-08 15:33 [RFC 1/3] [RFC iproute2-next] tc: f_u32: Rename commands and functions ip6 to ipv6 to unify naming Anton Danilov
2021-06-08 15:33 ` [RFC 2/3] [RFC iproute2-next] tc: f_u32: Fix the ipv6 pretty printing Anton Danilov
2021-06-15 2:57 ` Stephen Hemminger [this message]
2021-06-16 10:49 ` Anton Danilov
2021-06-08 15:33 ` [RFC 3/3] [RFC iproute2-next] tc: f_u32: fix the pretty print of ipv4 filters Anton Danilov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210614195700.260c8933@hermes.local \
--to=stephen@networkplumber.org \
--cc=littlesmilingcloud@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).