netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sergey Ryazanov <ryazanov.s.a@gmail.com>
To: Loic Poulain <loic.poulain@linaro.org>,
	Johannes Berg <johannes@sipsolutions.net>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, M Chetan Kumar <m.chetan.kumar@intel.com>,
	Intel Corporation <linuxwwan@intel.com>
Subject: [PATCH net-next 06/10] net: iosm: drop custom netdev(s) removing
Date: Tue, 15 Jun 2021 03:30:12 +0300	[thread overview]
Message-ID: <20210615003016.477-7-ryazanov.s.a@gmail.com> (raw)
In-Reply-To: <20210615003016.477-1-ryazanov.s.a@gmail.com>

Since the last commit, the WWAN core will remove all our network
interfaces for us at the time of the WWAN netdev ops unregistering.
Therefore, we can safely drop the custom code that cleaning the list of
created netdevs. Anyway it no longer removes any netdev, since all
netdevs were removed earlier in the wwan_unregister_ops() call.

Signed-off-by: Sergey Ryazanov <ryazanov.s.a@gmail.com>
CC: M Chetan Kumar <m.chetan.kumar@intel.com>
CC: Intel Corporation <linuxwwan@intel.com>
---
 drivers/net/wwan/iosm/iosm_ipc_wwan.c | 15 +--------------
 1 file changed, 1 insertion(+), 14 deletions(-)

diff --git a/drivers/net/wwan/iosm/iosm_ipc_wwan.c b/drivers/net/wwan/iosm/iosm_ipc_wwan.c
index 1711b79fc616..bee9b278223d 100644
--- a/drivers/net/wwan/iosm/iosm_ipc_wwan.c
+++ b/drivers/net/wwan/iosm/iosm_ipc_wwan.c
@@ -329,22 +329,9 @@ struct iosm_wwan *ipc_wwan_init(struct iosm_imem *ipc_imem, struct device *dev)
 
 void ipc_wwan_deinit(struct iosm_wwan *ipc_wwan)
 {
-	int if_id;
-
+	/* This call will remove all child netdev(s) */
 	wwan_unregister_ops(ipc_wwan->dev);
 
-	for (if_id = 0; if_id < ARRAY_SIZE(ipc_wwan->sub_netlist); if_id++) {
-		struct iosm_netdev_priv *priv;
-
-		priv = rcu_access_pointer(ipc_wwan->sub_netlist[if_id]);
-		if (!priv)
-			continue;
-
-		rtnl_lock();
-		ipc_wwan_dellink(ipc_wwan, priv->netdev, NULL);
-		rtnl_unlock();
-	}
-
 	mutex_destroy(&ipc_wwan->if_mutex);
 
 	kfree(ipc_wwan);
-- 
2.26.3


  parent reply	other threads:[~2021-06-15  0:31 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-15  0:30 [PATCH net-next 00/10] net: WWAN link creation improvements Sergey Ryazanov
2021-06-15  0:30 ` [PATCH net-next 01/10] wwan_hwsim: support network interface creation Sergey Ryazanov
2021-06-15  0:30 ` [PATCH net-next 02/10] wwan: core: relocate ops registering code Sergey Ryazanov
2021-06-15  0:30 ` [PATCH net-next 03/10] wwan: core: require WWAN netdev setup callback existence Sergey Ryazanov
2021-06-15  0:30 ` [PATCH net-next 04/10] wwan: core: multiple netdevs deletion support Sergey Ryazanov
2021-06-15  0:30 ` [PATCH net-next 05/10] wwan: core: remove all netdevs on ops unregistering Sergey Ryazanov
2021-06-15  0:30 ` Sergey Ryazanov [this message]
2021-06-20 15:20   ` [PATCH net-next 06/10] net: iosm: drop custom netdev(s) removing Sergey Ryazanov
2021-06-20 15:42     ` Kumar, M Chetan
2021-06-20 16:53       ` Sergey Ryazanov
2021-06-29 14:14       ` Loic Poulain
2021-06-29 14:56         ` Kumar, M Chetan
2021-06-29 15:29           ` Loic Poulain
2021-06-30  5:11             ` Kumar, M Chetan
2021-06-15  0:30 ` [PATCH net-next 07/10] wwan: core: no more hold netdev ops owning module Sergey Ryazanov
2021-06-15  0:30 ` [PATCH net-next 08/10] wwan: core: support default netdev creation Sergey Ryazanov
2021-06-15  0:30 ` [PATCH net-next 09/10] net: mhi_net: create default link via WWAN core Sergey Ryazanov
2021-06-15  7:17   ` Loic Poulain
2021-06-20 13:51     ` Sergey Ryazanov
2021-06-21  6:53       ` Loic Poulain
2021-06-21  9:54         ` Sergey Ryazanov
2021-06-15  0:30 ` [PATCH net-next 10/10] wwan: core: add WWAN common private data for netdev Sergey Ryazanov
2021-06-15  7:31   ` Johannes Berg
2021-06-20 14:49     ` Sergey Ryazanov
2021-06-15  7:33   ` Loic Poulain
2021-06-20 14:39     ` Sergey Ryazanov
2021-06-21  7:37       ` Loic Poulain
2021-06-21 17:22         ` Sergey Ryazanov
2021-06-22  7:21           ` Loic Poulain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210615003016.477-7-ryazanov.s.a@gmail.com \
    --to=ryazanov.s.a@gmail.com \
    --cc=davem@davemloft.net \
    --cc=johannes@sipsolutions.net \
    --cc=kuba@kernel.org \
    --cc=linuxwwan@intel.com \
    --cc=loic.poulain@linaro.org \
    --cc=m.chetan.kumar@intel.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).