From: Michael Ellerman <mpe@ellerman.id.au>
To: netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, kuba@kernel.org,
davem@davemloft.net, pv-drivers@vmware.com, doshir@vmware.com,
christophe.leroy@csgroup.eu
Subject: [PATCH] vmxnet3: prevent building with 256K pages
Date: Tue, 15 Jun 2021 22:35:04 +1000 [thread overview]
Message-ID: <20210615123504.547106-1-mpe@ellerman.id.au> (raw)
This driver assigns PAGE_SIZE to a u16, which can't work when the page
size is 256K. As reported by lkp:
drivers/net/vmxnet3/vmxnet3_drv.c: In function 'vmxnet3_rq_init':
arch/powerpc/include/asm/page.h:24:20: warning: conversion from 'long unsigned int' to 'u16' changes value from '262144' to '0'
drivers/net/vmxnet3/vmxnet3_drv.c:1784:29: note: in expansion of macro 'PAGE_SIZE'
1784 | rq->buf_info[0][i].len = PAGE_SIZE;
^~~~~~~~~
Simliar to what was done previously in commit fbdf0e28d061 ("vmxnet3:
prevent building with 64K pages"), prevent the driver from building when
256K pages are enabled.
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
---
drivers/net/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
index 74dc8e249faa..da46898f060a 100644
--- a/drivers/net/Kconfig
+++ b/drivers/net/Kconfig
@@ -549,7 +549,7 @@ config VMXNET3
depends on PCI && INET
depends on !(PAGE_SIZE_64KB || ARM64_64K_PAGES || \
IA64_PAGE_SIZE_64KB || MICROBLAZE_64K_PAGES || \
- PARISC_PAGE_SIZE_64KB || PPC_64K_PAGES)
+ PARISC_PAGE_SIZE_64KB || PPC_64K_PAGES || PPC_256K_PAGES)
help
This driver supports VMware's vmxnet3 virtual ethernet NIC.
To compile this driver as a module, choose M here: the
--
2.25.1
next reply other threads:[~2021-06-15 12:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-15 12:35 Michael Ellerman [this message]
2021-06-15 12:41 ` [PATCH] vmxnet3: prevent building with 256K pages Christophe Leroy
2021-06-16 5:21 ` Christoph Hellwig
2021-06-16 5:33 ` Christophe Leroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210615123504.547106-1-mpe@ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=christophe.leroy@csgroup.eu \
--cc=davem@davemloft.net \
--cc=doshir@vmware.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pv-drivers@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox