From: Kalle Valo <kvalo@codeaurora.org>
To: Yang Li <yang.lee@linux.alibaba.com>
Cc: pkshih@realtek.com, davem@davemloft.net, kuba@kernel.org,
nathan@kernel.org, ndesaulniers@google.com,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com,
Yang Li <yang.lee@linux.alibaba.com>
Subject: Re: [PATCH] rtlwifi: Remove redundant assignments to ul_enc_algo
Date: Tue, 15 Jun 2021 13:40:06 +0000 (UTC) [thread overview]
Message-ID: <20210615134006.5EC85C43144@smtp.codeaurora.org> (raw)
In-Reply-To: <1621303199-1542-1-git-send-email-yang.lee@linux.alibaba.com>
Yang Li <yang.lee@linux.alibaba.com> wrote:
> Variable ul_enc_algo is being initialized with a value that is never
> read, it is being set again in the following switch statements in
> all of the case and default paths. Hence the unitialization is
> redundant and can be removed.
>
> Clean up clang warning:
>
> drivers/net/wireless/realtek/rtlwifi/cam.c:170:6: warning: Value stored
> to 'ul_enc_algo' during its initialization is never read
> [clang-analyzer-deadcode.DeadStores]
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Patch applied to wireless-drivers-next.git, thanks.
a99086057e03 rtlwifi: Remove redundant assignments to ul_enc_algo
--
https://patchwork.kernel.org/project/linux-wireless/patch/1621303199-1542-1-git-send-email-yang.lee@linux.alibaba.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2021-06-15 13:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-18 1:59 [PATCH] rtlwifi: Remove redundant assignments to ul_enc_algo Yang Li
2021-06-15 13:40 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210615134006.5EC85C43144@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=clang-built-linux@googlegroups.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=netdev@vger.kernel.org \
--cc=pkshih@realtek.com \
--cc=yang.lee@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).