Re: [PATCH net-next] mdio: mdiobus: setup of_node for the MDIO device

[Ioana Ciornei <ciorneiioana@gmail.com>]

On Tue, Jun 15, 2021 at 06:19:26PM +0200, Andrew Lunn wrote:
> On Tue, Jun 15, 2021 at 06:44:01PM +0300, Ioana Ciornei wrote:
> > From: Ioana Ciornei <ioana.ciornei@nxp.com>
> > 
> > By mistake, the of_node of the MDIO device was not setup in the patch
> > linked below. As a consequence, any PHY driver that depends on the
> > of_node in its probe callback was not be able to successfully finish its
> > probe on a PHY
> 
> Do you mean the PHY driver was looking for things like RGMII delays,
> skew values etc?

In my case, the VSC8514 PHY driver was looking for the led modes
(vsc8531,led-%d-mode").

> 
> If the PHY driver fails to load because of missing OF properties, i
> guess this means the PHY driver will also fail in an ACPI system?
> 

Yes, it will.

The PHY drivers were not changed to use the fwnode_* calls
instead of the of_* ones. Unfortunately, I cannot test this with ACPI
since the boards that have this PHY (that I have access to) do not
support ACPI yet.

Ioana