From: Vladimir Oltean <olteanv@gmail.com>
To: Vadym Kochan <vadym.kochan@plvision.eu>
Cc: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
Taras Chornyi <tchornyi@marvell.com>,
linux-kernel@vger.kernel.org,
Mickey Rachamim <mickeyr@marvell.com>,
Serhiy Boiko <serhiy.boiko@plvision.eu>,
Volodymyr Mytnyk <vmytnyk@marvell.com>,
Vadym Kochan <vkochan@marvell.com>
Subject: Re: [PATCH net-next 1/2] net: marvell: Implement TC flower offload
Date: Wed, 16 Jun 2021 03:54:53 +0300 [thread overview]
Message-ID: <20210616005453.cuu3ocedgfcafa7o@skbuf> (raw)
In-Reply-To: <20210615125444.31538-2-vadym.kochan@plvision.eu>
On Tue, Jun 15, 2021 at 03:54:43PM +0300, Vadym Kochan wrote:
> +static int prestera_port_set_features(struct net_device *dev,
> + netdev_features_t features)
> +{
> + netdev_features_t oper_features = dev->features;
> + int err;
> +
> + err = prestera_port_handle_feature(dev, features, NETIF_F_HW_TC,
> + prestera_port_feature_hw_tc);
Why do you even make NETIF_F_HW_TC able to be toggled and not just fixed
to "on" in dev->features? If I understand correctly, you could then delete
a bunch of refcounting code whose only purpose is to allow that feature
to be disabled per port.
> +
> + if (err) {
> + dev->features = oper_features;
> + return -EINVAL;
> + }
> +
> + return 0;
> +}
next prev parent reply other threads:[~2021-06-16 0:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-15 12:54 [PATCH net-next 0/2] Marvell Prestera add flower and match all support Vadym Kochan
2021-06-15 12:54 ` [PATCH net-next 1/2] net: marvell: Implement TC flower offload Vadym Kochan
2021-06-16 0:54 ` Vladimir Oltean [this message]
2021-06-16 13:04 ` Vadym Kochan
2021-06-16 13:07 ` Vladimir Oltean
2021-06-15 12:54 ` [PATCH net-next 2/2] net: marvell: prestera: Add matchall support Vadym Kochan
2021-06-16 1:07 ` Vladimir Oltean
2021-06-15 18:37 ` [PATCH net-next 0/2] Marvell Prestera add flower and match all support David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210616005453.cuu3ocedgfcafa7o@skbuf \
--to=olteanv@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mickeyr@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=serhiy.boiko@plvision.eu \
--cc=tchornyi@marvell.com \
--cc=vadym.kochan@plvision.eu \
--cc=vkochan@marvell.com \
--cc=vmytnyk@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox