* [PATCH bpf-next] samples/bpf: Add missing option to xdp_fwd usage
@ 2021-06-15 13:55 Wang Hai
2021-06-16 10:52 ` Jesper Dangaard Brouer
0 siblings, 1 reply; 2+ messages in thread
From: Wang Hai @ 2021-06-15 13:55 UTC (permalink / raw)
To: davem, kuba, ast, daniel, hawk, john.fastabend, andrii, kafai,
songliubraving, yhs, kpsingh
Cc: bpf, netdev, linux-kernel
xdp_fwd usage() is missing the introduction of the "-S"
and "-F" options, this patch adds it.
Signed-off-by: Wang Hai <wanghai38@huawei.com>
---
samples/bpf/xdp_fwd_user.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/samples/bpf/xdp_fwd_user.c b/samples/bpf/xdp_fwd_user.c
index 74a4583d0d86..00061261a8da 100644
--- a/samples/bpf/xdp_fwd_user.c
+++ b/samples/bpf/xdp_fwd_user.c
@@ -67,6 +67,8 @@ static void usage(const char *prog)
"usage: %s [OPTS] interface-list\n"
"\nOPTS:\n"
" -d detach program\n"
+ " -S use skb-mode\n"
+ " -F force loading prog\n"
" -D direct table lookups (skip fib rules)\n",
prog);
}
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH bpf-next] samples/bpf: Add missing option to xdp_fwd usage
2021-06-15 13:55 [PATCH bpf-next] samples/bpf: Add missing option to xdp_fwd usage Wang Hai
@ 2021-06-16 10:52 ` Jesper Dangaard Brouer
0 siblings, 0 replies; 2+ messages in thread
From: Jesper Dangaard Brouer @ 2021-06-16 10:52 UTC (permalink / raw)
To: Wang Hai
Cc: brouer, davem, kuba, ast, daniel, hawk, john.fastabend, andrii,
kafai, songliubraving, yhs, kpsingh, bpf, netdev
On Tue, 15 Jun 2021 21:55:54 +0800
Wang Hai <wanghai38@huawei.com> wrote:
> xdp_fwd usage() is missing the introduction of the "-S"
> and "-F" options, this patch adds it.
>
> Signed-off-by: Wang Hai <wanghai38@huawei.com>
> ---
> samples/bpf/xdp_fwd_user.c | 2 ++
> 1 file changed, 2 insertions(+)
Fixes: d50ecc46d18f ("samples/bpf: Attach XDP programs in driver mode by default")
LGTM but please add "Fixes:" tag next time, I think patchwork will pick
this up via this reply.
Acked-by: Jesper Dangaard Brouer <brouer@redhat.com>
> diff --git a/samples/bpf/xdp_fwd_user.c b/samples/bpf/xdp_fwd_user.c
> index 74a4583d0d86..00061261a8da 100644
> --- a/samples/bpf/xdp_fwd_user.c
> +++ b/samples/bpf/xdp_fwd_user.c
> @@ -67,6 +67,8 @@ static void usage(const char *prog)
> "usage: %s [OPTS] interface-list\n"
> "\nOPTS:\n"
> " -d detach program\n"
> + " -S use skb-mode\n"
> + " -F force loading prog\n"
> " -D direct table lookups (skip fib rules)\n",
> prog);
> }
-
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-06-16 10:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-06-15 13:55 [PATCH bpf-next] samples/bpf: Add missing option to xdp_fwd usage Wang Hai
2021-06-16 10:52 ` Jesper Dangaard Brouer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).