From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51908C48BE6 for ; Wed, 16 Jun 2021 22:40:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3307E613F2 for ; Wed, 16 Jun 2021 22:40:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234213AbhFPWmr (ORCPT ); Wed, 16 Jun 2021 18:42:47 -0400 Received: from mail.kernel.org ([198.145.29.99]:39868 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233982AbhFPWmf (ORCPT ); Wed, 16 Jun 2021 18:42:35 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 10075613FE; Wed, 16 Jun 2021 22:40:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1623883228; bh=d6Nvp8CFbtJlZVKyUDorqHMbcgYl6GLqU1KYxPIyaoI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=A4rf70ewoc7ww+S1botaOEC/NVeQLpM0CtBd2W/MNzF1vRlzJj+UWIKz3SqjsIXa7 97ReFDqvRof3asZ6o7irGrOyxjKQcSoG2nfqvlh9oOq281VBJuJRUOWvZO2MA2zW/A ekoMb0QHAX4Yyg5pGL8iZ8Rq10T7clTpy5KonzVqFcGcYmc+/kbnosOmUuUBJOpzoM nWSyL3BTTZ2OnE5cWpOZ7cmbmV5eP7gIbFz0oVnH4466aS4qOqNKmbffxA+ZZAd5QW /fWJm4V8Az39NGuhkjuzm06wjCvMXyijTeUwoeEmPZ3LItg30Q+m52bOP0YNcbuaR9 VdSPyy0sBpAsA== From: Saeed Mahameed To: "David S. Miller" , Jakub Kicinski Cc: netdev@vger.kernel.org, Tariq Toukan , Parav Pandit , Yuval Avnery , Bodong Wang , Alaa Hleihel , Saeed Mahameed Subject: [net 4/8] net/mlx5: E-Switch, Allow setting GUID for host PF vport Date: Wed, 16 Jun 2021 15:40:11 -0700 Message-Id: <20210616224015.14393-5-saeed@kernel.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210616224015.14393-1-saeed@kernel.org> References: <20210616224015.14393-1-saeed@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Parav Pandit E-switch should be able to set the GUID of host PF vport. Currently it returns an error. This results in below error when user attempts to configure MAC address of the PF of an external controller. $ devlink port function set pci/0000:03:00.0/196608 \ hw_addr 00:00:00:11:22:33 mlx5_core 0000:03:00.0: mlx5_esw_set_vport_mac_locked:1876:(pid 6715):\ "Failed to set vport 0 node guid, err = -22. RDMA_CM will not function properly for this VF." Check for zero vport is no longer needed. Fixes: 330077d14de1 ("net/mlx5: E-switch, Supporting setting devlink port function mac address") Signed-off-by: Yuval Avnery Signed-off-by: Parav Pandit Reviewed-by: Bodong Wang Reviewed-by: Alaa Hleihel Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/vport.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/vport.c b/drivers/net/ethernet/mellanox/mlx5/core/vport.c index 457ad42eaa2a..4c1440a95ad7 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/vport.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/vport.c @@ -465,8 +465,6 @@ int mlx5_modify_nic_vport_node_guid(struct mlx5_core_dev *mdev, void *in; int err; - if (!vport) - return -EINVAL; if (!MLX5_CAP_GEN(mdev, vport_group_manager)) return -EACCES; -- 2.31.1