From: Vladimir Oltean <olteanv@gmail.com>
To: Vadym Kochan <vadym.kochan@plvision.eu>
Cc: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Jamal Hadi Salim <jhs@mojatatu.com>,
Cong Wang <xiyou.wangcong@gmail.com>,
Andrew Lunn <andrew@lunn.ch>,
Serhiy Boiko <serhiy.boiko@plvision.eu>,
Volodymyr Mytnyk <volodymyr.mytnyk@plvision.eu>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Boris Sukholitko <boris.sukholitko@broadcom.com>
Subject: Re: [PATCH net-next] net/sched: cls_flower: fix resetting of ether proto mask
Date: Thu, 17 Jun 2021 19:41:55 +0300 [thread overview]
Message-ID: <20210617164155.li3fct6ad45a6j7h@skbuf> (raw)
In-Reply-To: <20210617161435.8853-1-vadym.kochan@plvision.eu>
On Thu, Jun 17, 2021 at 07:14:35PM +0300, Vadym Kochan wrote:
> In case of matching 'protocol' the rule does not work:
>
> tc filter add dev $DEV ingress prio 1 protocol $PROTO flower skip_sw action drop
>
> so clear the ether proto mask only for CVLAN case.
>
> The issue was observed by testing on Marvell Prestera Switchdev driver
> with recent 'flower' offloading feature.
>
> Fixes: 0dca2c7404a9 ("net/sched: cls_flower: Remove match on n_proto")
> CC: Boris Sukholitko <boris.sukholitko@broadcom.com>
> Signed-off-by: Vadym Kochan <vadym.kochan@plvision.eu>
> ---
You resent the patch very quickly, did you find out why Boris' patch was
working in the first place?
next prev parent reply other threads:[~2021-06-17 16:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-17 16:14 [PATCH net-next] net/sched: cls_flower: fix resetting of ether proto mask Vadym Kochan
2021-06-17 16:41 ` Vladimir Oltean [this message]
2021-06-17 19:51 ` Vladimir Oltean
2021-06-21 8:32 ` Boris Sukholitko
2021-06-21 10:09 ` Vladimir Oltean
2021-06-21 14:04 ` Jamal Hadi Salim
2021-06-22 13:13 ` Boris Sukholitko
2021-06-22 14:17 ` Jamal Hadi Salim
2021-06-22 15:22 ` Boris Sukholitko
2021-06-24 20:07 ` Jamal Hadi Salim
2021-06-28 6:24 ` Boris Sukholitko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210617164155.li3fct6ad45a6j7h@skbuf \
--to=olteanv@gmail.com \
--cc=andrew@lunn.ch \
--cc=boris.sukholitko@broadcom.com \
--cc=davem@davemloft.net \
--cc=jhs@mojatatu.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=serhiy.boiko@plvision.eu \
--cc=vadym.kochan@plvision.eu \
--cc=volodymyr.mytnyk@plvision.eu \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox