* [PATCH] ice: change return type of ice_ptp_request_ts() to s8
@ 2021-06-17 21:54 trix
2021-06-17 23:25 ` Nguyen, Anthony L
0 siblings, 1 reply; 2+ messages in thread
From: trix @ 2021-06-17 21:54 UTC (permalink / raw)
To: jesse.brandeburg, anthony.l.nguyen, davem, kuba
Cc: intel-wired-lan, netdev, linux-kernel, Tom Rix
From: Tom Rix <trix@redhat.com>
A gcc 10.3.1 compile error
ice_ptp.h:149:1: error: return type defaults to
'int' [-Werror=return-type]
149 | ice_ptp_request_ts(struct ice_ptp_tx *tx, ...
| ^~~~~~~~~~~~~~~~~~
This stub's return needs to match the decl for
CONFIG_PTP_I588_CLOCK, which matches its use in
ice_txrt.c
Change the implicit int return to s8.
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/net/ethernet/intel/ice/ice_ptp.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/ice/ice_ptp.h b/drivers/net/ethernet/intel/ice/ice_ptp.h
index 41e14f98f0e66..d01507eba0364 100644
--- a/drivers/net/ethernet/intel/ice/ice_ptp.h
+++ b/drivers/net/ethernet/intel/ice/ice_ptp.h
@@ -145,7 +145,7 @@ static inline int ice_get_ptp_clock_index(struct ice_pf *pf)
return -1;
}
-static inline
+static inline s8
ice_ptp_request_ts(struct ice_ptp_tx *tx, struct sk_buff *skb)
{
return -1;
--
2.26.3
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] ice: change return type of ice_ptp_request_ts() to s8
2021-06-17 21:54 [PATCH] ice: change return type of ice_ptp_request_ts() to s8 trix
@ 2021-06-17 23:25 ` Nguyen, Anthony L
0 siblings, 0 replies; 2+ messages in thread
From: Nguyen, Anthony L @ 2021-06-17 23:25 UTC (permalink / raw)
To: davem@davemloft.net, trix@redhat.com, Brandeburg, Jesse,
kuba@kernel.org
Cc: netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org,
linux-kernel@vger.kernel.org
On Thu, 2021-06-17 at 14:54 -0700, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
>
> A gcc 10.3.1 compile error
> ice_ptp.h:149:1: error: return type defaults to
> 'int' [-Werror=return-type]
> 149 | ice_ptp_request_ts(struct ice_ptp_tx *tx, ...
> | ^~~~~~~~~~~~~~~~~~
>
> This stub's return needs to match the decl for
> CONFIG_PTP_I588_CLOCK, which matches its use in
> ice_txrt.c
>
> Change the implicit int return to s8.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
Thanks for the patch Tom, but Lorenzo recently had the fix accepted for
this[1].
- Tony
[1] https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-
next.git/commit/?id=4d7f75fe8006a1345e6a52b3e3a4c82633f20564
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-06-17 23:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-06-17 21:54 [PATCH] ice: change return type of ice_ptp_request_ts() to s8 trix
2021-06-17 23:25 ` Nguyen, Anthony L
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).