From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 184C5C48BE5 for ; Mon, 21 Jun 2021 17:58:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 045BD61358 for ; Mon, 21 Jun 2021 17:58:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232712AbhFUSAo (ORCPT ); Mon, 21 Jun 2021 14:00:44 -0400 Received: from mail.kernel.org ([198.145.29.99]:39666 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233350AbhFUR6R (ORCPT ); Mon, 21 Jun 2021 13:58:17 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 52F8A611CE; Mon, 21 Jun 2021 17:54:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1624298044; bh=eM2rhk2kL5c6dVU2ybax6brBIgOwt4Ta8MvU1pHwI5E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ChBCb8+KxgYRvCavrY7mJuxc30+VGg/F6oj756FXBQbUBhlShfxd0GbxwOcPeFs8q eS5aWxovPy4+wCb9kteuDEDVvTyZruaBSmWiGEBGvETybCaIjgwXWYFYO0GpzoshR5 7OiUjdgnZAZ+zZ2kShAbDqoplRr6WKzsDlmzNjB2D76hVIAKWOcD1u90rUdB5CkKwL s4IUyRckaTLgi9awgXBR1DSa4Jo6Pu+p1VQjrx+cme3Bo/rUh4J7Ro8gADNhkpIu5B bvGmro7jwIxTqjbI/cZin2KdRTxy0wi98Gp2CEh3pHklF9XmBZ+PAySzZMYPmQJWjJ vbUeLbMOM+ejQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Johannes Berg , syzbot+7716dbc401d9a437890d@syzkaller.appspotmail.com, Sasha Levin , linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 5.4 02/26] mac80211: remove warning in ieee80211_get_sband() Date: Mon, 21 Jun 2021 13:53:35 -0400 Message-Id: <20210621175400.735800-2-sashal@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210621175400.735800-1-sashal@kernel.org> References: <20210621175400.735800-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Johannes Berg [ Upstream commit 0ee4d55534f82a0624701d0bb9fc2304d4529086 ] Syzbot reports that it's possible to hit this from userspace, by trying to add a station before any other connection setup has been done. Instead of trying to catch this in some other way simply remove the warning, that will appropriately reject the call from userspace. Reported-by: syzbot+7716dbc401d9a437890d@syzkaller.appspotmail.com Link: https://lore.kernel.org/r/20210517164715.f537da276d17.Id05f40ec8761d6a8cc2df87f1aa09c651988a586@changeid Signed-off-by: Johannes Berg Signed-off-by: Sasha Levin --- net/mac80211/ieee80211_i.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/mac80211/ieee80211_i.h b/net/mac80211/ieee80211_i.h index a7933279a80b..e574fbf6745a 100644 --- a/net/mac80211/ieee80211_i.h +++ b/net/mac80211/ieee80211_i.h @@ -1420,7 +1420,7 @@ ieee80211_get_sband(struct ieee80211_sub_if_data *sdata) rcu_read_lock(); chanctx_conf = rcu_dereference(sdata->vif.chanctx_conf); - if (WARN_ON_ONCE(!chanctx_conf)) { + if (!chanctx_conf) { rcu_read_unlock(); return NULL; } -- 2.30.2