From: Pavel Skripkin <paskripkin@gmail.com>
To: Christian Lamparter <chunkeey@gmail.com>
Cc: kvalo@codeaurora.org, davem@davemloft.net,
Yang Yingliang <yangyingliang@huawei.com>,
ath10k@lists.infradead.org, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [PATCH] net: ath10: add missing ret initialization
Date: Wed, 23 Jun 2021 22:26:20 +0300 [thread overview]
Message-ID: <20210623222620.06b6335a@gmail.com> (raw)
In-Reply-To: <a0805010-788a-5ff8-2e6e-34e7ded8c34b@gmail.com>
On Wed, 23 Jun 2021 21:23:27 +0200
Christian Lamparter <chunkeey@gmail.com> wrote:
> On 23/06/2021 21:14, Pavel Skripkin wrote:
> > In case of not supported chip the code jump
> > to the error handling path, but _ret_ will be set to 0.
> > Returning 0 from probe means, that ->probe() succeeded, but
> > it's not true when chip is not supported.
> >
> > Fixes: f8914a14623a ("ath10k: restore QCA9880-AR1A (v1) detection")
> > Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
>
> I think this is already fixed by:
>
> commit e2783e2f39ba99178dedfc1646d5cc0979d1bab3
> Author: Yang Yingliang <yangyingliang@huawei.com>
> Date: Mon May 31 17:41:28 2021 +0300
>
> ath10k: add missing error return code in ath10k_pci_probe()
>
>
Ah, i didn't check linux-next tree, my bad :(
Thanks for pointing it out
With regards,
Pavel Skripkin
prev parent reply other threads:[~2021-06-23 19:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-23 19:14 [PATCH] net: ath10: add missing ret initialization Pavel Skripkin
2021-06-23 19:23 ` Christian Lamparter
2021-06-23 19:26 ` Pavel Skripkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210623222620.06b6335a@gmail.com \
--to=paskripkin@gmail.com \
--cc=ath10k@lists.infradead.org \
--cc=chunkeey@gmail.com \
--cc=davem@davemloft.net \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).