From: Kalle Valo <kvalo@codeaurora.org>
To: Lv Yunlong <lyl2019@mail.ustc.edu.cn>
Cc: j@w1.fi, davem@davemloft.net, kuba@kernel.org,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
Lv Yunlong <lyl2019@mail.ustc.edu.cn>
Subject: Re: [PATCH] wireless: hostap: Fix a use after free in hostap_80211_rx
Date: Thu, 24 Jun 2021 16:41:39 +0000 (UTC) [thread overview]
Message-ID: <20210624164139.2CFA8C433D3@smtp.codeaurora.org> (raw)
In-Reply-To: <20210329110021.7497-1-lyl2019@mail.ustc.edu.cn>
Lv Yunlong <lyl2019@mail.ustc.edu.cn> wrote:
> Function hostap_80211_rx() calls prism2_rx_80211(..,skb,..). In
> prism2_rx_80211, i found that the skb could be freed by dev_kfree_skb_any(skb)
> and return 0. Also could be freed by netif_rx(skb) when netif_rx return
> NET_RX_DROP.
>
> But after called the prism2_rx_80211(..,skb,..), the skb is used by skb->len.
>
> As the new skb->len is returned by prism2_rx_80211(), my patch uses a variable
> len to repalce skb->len. According to another useage of prism2_rx_80211 in
> monitor_rx().
>
> Signed-off-by: Lv Yunlong <lyl2019@mail.ustc.edu.cn>
Can someone help with reviewing the patch?
--
https://patchwork.kernel.org/project/linux-wireless/patch/20210329110021.7497-1-lyl2019@mail.ustc.edu.cn/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2021-06-24 16:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-29 11:00 [PATCH] wireless: hostap: Fix a use after free in hostap_80211_rx Lv Yunlong
2021-06-24 16:41 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210624164139.2CFA8C433D3@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=davem@davemloft.net \
--cc=j@w1.fi \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lyl2019@mail.ustc.edu.cn \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).