From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7453CC48BC2 for ; Fri, 25 Jun 2021 06:42:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 501E061351 for ; Fri, 25 Jun 2021 06:42:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233215AbhFYGpA (ORCPT ); Fri, 25 Jun 2021 02:45:00 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:34336 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230097AbhFYGo5 (ORCPT ); Fri, 25 Jun 2021 02:44:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1624603356; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=G9jRj0tpYxmkhpGWsyUbyAZnE8Gx5cKf3gFKh8399ko=; b=A4Q0NnSaVK36qAeSNRrojEuxxUNMwgK4qaMCzNX1BeVzY8hRGG96ZwXN9cMHo4kaKIFhw2 4kgQXDifLXjqBgIbZbB6xyV2xx/M3DhRPc2BtMqzvH36+FQo2tte/CgMOstddA2kO1R+y4 6Ve+Xxlaw42UHn04RH/oy5V26VOyYHA= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-358-6Zeb36uLMVCEZQt49_1ukA-1; Fri, 25 Jun 2021 02:42:35 -0400 X-MC-Unique: 6Zeb36uLMVCEZQt49_1ukA-1 Received: by mail-wr1-f69.google.com with SMTP id j1-20020adfb3010000b02901232ed22e14so3141070wrd.5 for ; Thu, 24 Jun 2021 23:42:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=G9jRj0tpYxmkhpGWsyUbyAZnE8Gx5cKf3gFKh8399ko=; b=rU9DWhgJ7UTfoA3lhkwIcjpgfTXUlBGgGqTdx8yLtAiajR49HZOviPaobLx0HXvh6R MMV0QQA4NcQo3Ll39hexEkpoL9J1tp1315zPvgFqYyTHqa25HBAcqr88U6MFzuqlqayG UwkoDTfgJsMQR1LJR0XQkD23uFvMsB/3ku6fLwQ4gieA9pEZ2u9yq35wNbnQqRNy7Blm 6dqVt3m6oT27WzD+5HzQWyQAyGm1e1ue6ufkDHHLaYbc+7XHAc8EDbsRfPYDLKLxxtrF l6Vx77gHMPzuhXPtsIbAXJXdskBEtcLaDx07go1hxHT9b05Q3R6DyChE6ZigIhCSu0IA WwFQ== X-Gm-Message-State: AOAM533IofgTyCt5sd+O2R4w+4HefExTXN/9v7AyyJP5Lkxak9YJbWmp CMfEQv2g6kqNo+J02H5Wb/n90RYqzVWEge+8uSCrlJdXDLvP9LvXjo/y7D27YTBZwv6us6WAU1Q pxMPS9TNnF1ls/n1F X-Received: by 2002:a5d:6b82:: with SMTP id n2mr8884405wrx.206.1624603354054; Thu, 24 Jun 2021 23:42:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw92gxo6icRkyIW2W9jDfsnK0lVx5O0U/fJfH24QR4NPITd1aULbry65dD0d5lmfFtShv6qCw== X-Received: by 2002:a5d:6b82:: with SMTP id n2mr8884384wrx.206.1624603353946; Thu, 24 Jun 2021 23:42:33 -0700 (PDT) Received: from redhat.com ([77.124.79.210]) by smtp.gmail.com with ESMTPSA id v18sm5762831wrv.24.2021.06.24.23.42.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Jun 2021 23:42:33 -0700 (PDT) Date: Fri, 25 Jun 2021 02:42:04 -0400 From: "Michael S. Tsirkin" To: Yunsheng Lin Cc: davem@davemloft.net, kuba@kernel.org, jasowang@redhat.com, brouer@redhat.com, paulmck@kernel.org, peterz@infradead.org, will@kernel.org, shuah@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-kselftest@vger.kernel.org, linuxarm@openeuler.org Subject: Re: [PATCH net-next v2 0/2] add benchmark selftest and optimization for ptr_ring Message-ID: <20210625024131-mutt-send-email-mst@kernel.org> References: <1624591136-6647-1-git-send-email-linyunsheng@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1624591136-6647-1-git-send-email-linyunsheng@huawei.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Jun 25, 2021 at 11:18:54AM +0800, Yunsheng Lin wrote: > Patch 1: add a selftest app to benchmark the performance > of ptr_ring. > Patch 2: make __ptr_ring_empty() checking more reliable > and use the just added selftest to benchmark the > performance impact. > > V2: add patch 1 and add performance data for patch 2. Thanks for the patches! There are some things to improve there - I sent comments in response to invididual patches. > Yunsheng Lin (2): > selftests/ptr_ring: add benchmark application for ptr_ring > ptr_ring: make __ptr_ring_empty() checking more reliable > > MAINTAINERS | 5 + > include/linux/ptr_ring.h | 25 ++- > tools/testing/selftests/ptr_ring/Makefile | 6 + > tools/testing/selftests/ptr_ring/ptr_ring_test.c | 249 +++++++++++++++++++++++ > tools/testing/selftests/ptr_ring/ptr_ring_test.h | 150 ++++++++++++++ > 5 files changed, 426 insertions(+), 9 deletions(-) > create mode 100644 tools/testing/selftests/ptr_ring/Makefile > create mode 100644 tools/testing/selftests/ptr_ring/ptr_ring_test.c > create mode 100644 tools/testing/selftests/ptr_ring/ptr_ring_test.h > > -- > 2.7.4