From: Vladimir Oltean <olteanv@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org
Cc: Florian Fainelli <f.fainelli@gmail.com>,
Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Tobias Waldekranz <tobias@waldekranz.com>,
Jiri Pirko <jiri@resnulli.us>, Ido Schimmel <idosch@idosch.org>,
Roopa Prabhu <roopa@nvidia.com>,
Nikolay Aleksandrov <nikolay@nvidia.com>,
Vladimir Oltean <vladimir.oltean@nxp.com>
Subject: Re: [PATCH net-next 4/7] net: bridge: ignore switchdev events for LAG ports which didn't request replay
Date: Sat, 26 Jun 2021 00:48:52 +0300 [thread overview]
Message-ID: <20210625214852.sjdmjv3jq4rjszea@skbuf> (raw)
In-Reply-To: <20210625185321.626325-5-olteanv@gmail.com>
On Fri, Jun 25, 2021 at 09:53:18PM +0300, Vladimir Oltean wrote:
> @@ -166,7 +168,7 @@ bool br_port_flag_is_set(const struct net_device *dev, unsigned long flag);
> u8 br_port_get_stp_state(const struct net_device *dev);
> clock_t br_get_ageing_time(struct net_device *br_dev);
> int br_fdb_replay(struct net_device *br_dev, struct net_device *dev,
> - struct notifier_block *nb);
> + void *ctx, struct notifier_block *nb);
> #else
> static inline struct net_device *
> br_fdb_find_port(const struct net_device *br_dev,
Damn, I forgot a "const void *" here and it blew up everything.
Sorry, my fault. I'll use the extra time to test the patches some more
and give reviewers more time, will resend some time tomorrow.
next prev parent reply other threads:[~2021-06-25 21:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-25 18:53 [PATCH net-next 0/7] Cleanup for the bridge replay helpers Vladimir Oltean
2021-06-25 18:53 ` [PATCH net-next 1/7] net: bridge: include the is_local bit in br_fdb_replay Vladimir Oltean
2021-06-27 2:55 ` Florian Fainelli
2021-06-25 18:53 ` [PATCH net-next 2/7] net: ocelot: delete call to br_fdb_replay Vladimir Oltean
2021-06-27 2:55 ` Florian Fainelli
2021-06-25 18:53 ` [PATCH net-next 3/7] net: switchdev: add a context void pointer to struct switchdev_notifier_info Vladimir Oltean
2021-06-27 2:58 ` Florian Fainelli
2021-06-25 18:53 ` [PATCH net-next 4/7] net: bridge: ignore switchdev events for LAG ports which didn't request replay Vladimir Oltean
2021-06-25 21:48 ` Vladimir Oltean [this message]
2021-06-27 2:59 ` Florian Fainelli
2021-06-25 18:53 ` [PATCH net-next 5/7] net: bridge: constify variables in the replay helpers Vladimir Oltean
2021-06-27 2:56 ` Florian Fainelli
2021-06-25 18:53 ` [PATCH net-next 6/7] net: bridge: allow the switchdev replay functions to be called for deletion Vladimir Oltean
2021-06-27 3:01 ` Florian Fainelli
2021-06-25 18:53 ` [PATCH net-next 7/7] net: dsa: replay a deletion of switchdev objects for ports leaving a bridged LAG Vladimir Oltean
2021-06-27 3:01 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210625214852.sjdmjv3jq4rjszea@skbuf \
--to=olteanv@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=idosch@idosch.org \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nikolay@nvidia.com \
--cc=roopa@nvidia.com \
--cc=tobias@waldekranz.com \
--cc=vivien.didelot@gmail.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox