netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Alexander Aring <aahringo@redhat.com>, netdev@vger.kernel.org
Cc: kbuild-all@lists.01.org, davem@davemloft.net, kuba@kernel.org
Subject: Re: [PATCH net-next 1/2] net: sock: introduce sk_error_report
Date: Sat, 26 Jun 2021 08:19:27 +0800	[thread overview]
Message-ID: <202106260850.aY7EUCLE-lkp@intel.com> (raw)
In-Reply-To: <20210625191822.77721-2-aahringo@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 2163 bytes --]

Hi Alexander,

I love your patch! Yet something to improve:

[auto build test ERROR on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Alexander-Aring/net-sock-add-tracers-for-inet-socket-errors/20210626-031959
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 19938bafa7ae8fc0a4a2c1c1430abb1a04668da1
config: mips-randconfig-r035-20210622 (attached as .config)
compiler: mips64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/23e631bac02c834a4d4e560e317bf7907d874484
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Alexander-Aring/net-sock-add-tracers-for-inet-socket-errors/20210626-031959
        git checkout 23e631bac02c834a4d4e560e317bf7907d874484
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=mips 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   net/qrtr/qrtr.c: In function 'qrtr_reset_ports':
>> net/qrtr/qrtr.c:754:3: error: 'sk' undeclared (first use in this function); did you mean 's8'?
     754 |   sk.sk_error_report(&ipc->sk);
         |   ^~
         |   s8
   net/qrtr/qrtr.c:754:3: note: each undeclared identifier is reported only once for each function it appears in


vim +754 net/qrtr/qrtr.c

   743	
   744	/* Reset all non-control ports */
   745	static void qrtr_reset_ports(void)
   746	{
   747		struct qrtr_sock *ipc;
   748		unsigned long index;
   749	
   750		rcu_read_lock();
   751		xa_for_each_start(&qrtr_ports, index, ipc, 1) {
   752			sock_hold(&ipc->sk);
   753			ipc->sk.sk_err = ENETRESET;
 > 754			sk.sk_error_report(&ipc->sk);
   755			sock_put(&ipc->sk);
   756		}
   757		rcu_read_unlock();
   758	}
   759	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 25738 bytes --]

  reply	other threads:[~2021-06-26  0:20 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-25 19:18 [PATCH net-next 0/2] net: sock: add tracers for inet socket errors Alexander Aring
2021-06-25 19:18 ` [PATCH net-next 1/2] net: sock: introduce sk_error_report Alexander Aring
2021-06-26  0:19   ` kernel test robot [this message]
2021-06-26  3:30   ` kernel test robot
2021-06-26  3:40   ` kernel test robot
2021-06-25 19:18 ` [PATCH net-next 2/2] net: sock: add trace for socket errors Alexander Aring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202106260850.aY7EUCLE-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=aahringo@redhat.com \
    --cc=davem@davemloft.net \
    --cc=kbuild-all@lists.01.org \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).