From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB883C49EA3 for ; Mon, 28 Jun 2021 12:05:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B947D61C71 for ; Mon, 28 Jun 2021 12:05:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232958AbhF1MII (ORCPT ); Mon, 28 Jun 2021 08:08:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60456 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232926AbhF1MIF (ORCPT ); Mon, 28 Jun 2021 08:08:05 -0400 Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BAB6FC061766; Mon, 28 Jun 2021 05:05:36 -0700 (PDT) Received: from ktm (85-222-111-42.dynamic.chello.pl [85.222.111.42]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: lukma@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 0FCAC82DBA; Mon, 28 Jun 2021 14:05:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1624881933; bh=UIyRjwy0vFnK2UZowXIaRpxAMqdxk5niHOiRA8DOgxg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=zJ0tKC7qc4492AcJQEgN+To4LYQYAQyDrZ9B0yK+5edUSoaOhpoJAx2UDFMw1WPUI lUSSTaTkSxeKqAKLhzJJigposDp0oxaXGJyEMm/0WSpR9haz01yeaDByANk/CTGJ7y UyG1g2M+jemyGc6Gn77TqQfVHU0xop8SLE1pcNsyhz51AMhpQvomXqASy1u25PuWLL y9X5o/H0s/rucmg8bjMtgWCYbRSjm+yBoJvLKE5Ip6O1tm6mlJtVrDYN8BLkyIAVav ktv3laFgdkOZ3JP4TpA9xNuA9oObXzkypNy5nb3dgryNkLrF6Ud9zXfclQbDyPbL4X W2Owvz2P6ExZQ== Date: Mon, 28 Jun 2021 14:05:26 +0200 From: Lukasz Majewski To: Andrew Lunn Cc: "David S . Miller" , Jakub Kicinski , Madalin Bucur , Nicolas Ferre , Joakim Zhang , Florian Fainelli , Vladimir Oltean , netdev@vger.kernel.org, Arnd Bergmann , Mark Einon , NXP Linux Team , linux-kernel@vger.kernel.org Subject: Re: [RFC 2/3] net: Provide switchdev driver for NXP's More Than IP L2 switch Message-ID: <20210628140526.7417fbf2@ktm> In-Reply-To: References: <20210622144111.19647-1-lukma@denx.de> <20210622144111.19647-3-lukma@denx.de> <20210623133704.334a84df@ktm> <20210624125304.36636a44@ktm> <20210624163542.5b6d87ee@ktm> <20210625115935.132922ff@ktm> Organization: denx.de X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/oRs4Gqruek3169mZ2ms_wVj"; protocol="application/pgp-signature" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org --Sig_/oRs4Gqruek3169mZ2ms_wVj Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi Andrew, > > I do believe that I can just extend the L2 switch driver (fec_mtip.c > > file to be precise) to provide full blown L2 switch functionality > > without touching the legacy FEC more than in this patch set. > >=20 > > Would you consider applying this patch series then? =20 >=20 > What is most important is the ABI. If something is merged now, we need > to ensure it does not block later refactoring to a clean new > driver. The DT binding is considered ABI. So the DT binding needs to > be like a traditional switchdev driver. Florian already pointed out, > you can use a binding very similar to DSA. ti,cpsw-switch.yaml is > another good example. The best I could get would be: ð_switch { compatible =3D "imx,mtip-l2switch"; reg =3D <0x800f8000 0x400>, <0x800fC000 0x4000>; interrupts =3D <100>; status =3D "okay"; ethernet-ports { port1@1 { reg =3D <1>; label =3D "eth0"; phys =3D <&mac0 0>; }; port2@2 { reg =3D <2>; label =3D "eth1"; phys =3D <&mac1 1>; }; }; }; Which would abuse the "phys" properties usages - as 'mac[01]' are referring to ethernet controllers. On TI SoCs (e.g. am33xx-l4.dtsi) phys refer to some separate driver responsible for PHY management. On NXP this is integrated with FEC driver itself. >=20 > So before considering merging your changes, i would like to see a > usable binding. >=20 > I also don't remember seeing support for STP. Without that, your > network has broadcast storm problems when there are loops. So i would > like to see the code needed to put ports into blocking, listening, > learning, and forwarding states. >=20 > Andrew Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de --Sig_/oRs4Gqruek3169mZ2ms_wVj Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEgAyFJ+N6uu6+XupJAR8vZIA0zr0FAmDZuwYACgkQAR8vZIA0 zr2RcAgAuMY1iZZF2X1EHM9gUTLF569/9gcgivWFrvNEChAKx5zHxpIbgzxPAnwm GzabIwg2N4OIHd1QGNR9zWxba3EnRbAG9+YdcGNIY6XN9wR7qe5LUjLpyg3kyica hlSc5lqCeXhZYzPEIyUx1t8mc14J7aUw4s09YSkqWFWpDd2vbCgJGuExIM/qrOE9 ZI1ramBtlAMNvA6aJmpTM9tJTIb3Ih9gqqJVSpsLSkn4iVYeYWO0OT0HNncnAf5p 3clvENVZPplWGGwedpyCMyRvu5Q/Ww7pce6YdJ42RmTFeBw0xHjHPbvcrYj+qspD oapmrFJvImA1Gc1aerNhuLtH+UWgEg== =ZPz6 -----END PGP SIGNATURE----- --Sig_/oRs4Gqruek3169mZ2ms_wVj--