From: "Marek Behún" <kabel@kernel.org>
To: Kurt Cancemi <kurt@x64architecture.com>
Cc: Marcin Wojtas <mw@semihalf.com>, netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH 1/1] net: phy: marvell: Fixed handing of delays with plain RGMII interface
Date: Tue, 29 Jun 2021 02:21:06 +0200 [thread overview]
Message-ID: <20210629022106.58925d5f@thinkpad> (raw)
In-Reply-To: <CADujJWW=QbsRcrvF+7UxWZssMJ0iK1+xq+mfCTAVb7SkKKXcaA@mail.gmail.com>
On Mon, 28 Jun 2021 20:05:19 -0400
Kurt Cancemi <kurt@x64architecture.com> wrote:
> Well I'm sorry for the noise I was running into a lot of other DPAA
> ethernet related issues and overlooked adding phy-mode = "rgmii-id";
> that fixed the issue. I knew my patch was not correct (as I explained
> in the cover email) but I was not sure why it was necessary but now I
> see it was not necessary I just had "phy-connection-mode" instead of
> "phy-mode".
>
> May I ask what is the purpose of phy-connection-mode? And why did the
phy-connection-type, not mode
> DPAA driver recognize the PHY interface mode as RGMII ID but the
> Marvell PHY driver didn't?
phy-mode and phy-connection-type are synonyms. phy-mode takes
precedence. Look at drivers/of/of_net.c function of_get_phy_mode().
If your device tree declares both, it can lead to confusion. For
example if dtsi file says
phy-mode = "rgmii";
and you include this dtsi file but than you say
phy-connection-type = "rgmii-id";
the kernel code will use rgmii, not rgmii-id, because phy-mode takes
precedence over phy-connection-type.
Marek
next prev parent reply other threads:[~2021-06-29 0:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-28 19:28 [PATCH 0/1] Possible Issue Setting the Delay Flags in the Marvell Net PHY Driver Kurt Cancemi
2021-06-28 19:28 ` [PATCH 1/1] net: phy: marvell: Fixed handing of delays with plain RGMII interface Kurt Cancemi
2021-06-28 22:49 ` Marek Behún
2021-06-28 23:01 ` Marcin Wojtas
2021-06-29 0:05 ` Kurt Cancemi
2021-06-29 0:21 ` Marek Behún [this message]
[not found] ` <CADujJWWoWRyW3S+f3F_Zhq9H90QZ1W4eu=5dyad3DeMLHFp2TA@mail.gmail.com>
2021-06-29 0:23 ` Marek Behún
2021-06-29 1:12 ` Kurt Cancemi
2021-06-29 10:52 ` Marek Behún
2021-06-29 15:08 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210629022106.58925d5f@thinkpad \
--to=kabel@kernel.org \
--cc=kurt@x64architecture.com \
--cc=mw@semihalf.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).