From: "Marek Behún" <kabel@kernel.org>
To: netdev@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>
Cc: "David S . Miller" <davem@davemloft.net>,
"Jakub Kicinski" <kuba@kernel.org>,
"Marek Behún" <kabel@kernel.org>
Subject: [PATCH net v2 2/6] net: dsa: mv88e6xxx: use correct .stats_set_histogram() on Topaz
Date: Thu, 1 Jul 2021 00:22:27 +0200 [thread overview]
Message-ID: <20210630222231.2297-3-kabel@kernel.org> (raw)
In-Reply-To: <20210630222231.2297-1-kabel@kernel.org>
Commit 40cff8fca9e3 ("net: dsa: mv88e6xxx: Fix stats histogram mode")
introduced wrong .stats_set_histogram() method for Topaz family.
The Peridot method should be used instead.
Signed-off-by: Marek Behún <kabel@kernel.org>
Fixes: 40cff8fca9e3 ("net: dsa: mv88e6xxx: Fix stats histogram mode")
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
---
drivers/net/dsa/mv88e6xxx/chip.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c
index 6bcee3e012d4..b125d3227dbd 100644
--- a/drivers/net/dsa/mv88e6xxx/chip.c
+++ b/drivers/net/dsa/mv88e6xxx/chip.c
@@ -3597,7 +3597,7 @@ static const struct mv88e6xxx_ops mv88e6141_ops = {
.port_set_cmode = mv88e6341_port_set_cmode,
.port_setup_message_port = mv88e6xxx_setup_message_port,
.stats_snapshot = mv88e6390_g1_stats_snapshot,
- .stats_set_histogram = mv88e6095_g1_stats_set_histogram,
+ .stats_set_histogram = mv88e6390_g1_stats_set_histogram,
.stats_get_sset_count = mv88e6320_stats_get_sset_count,
.stats_get_strings = mv88e6320_stats_get_strings,
.stats_get_stats = mv88e6390_stats_get_stats,
@@ -4398,7 +4398,7 @@ static const struct mv88e6xxx_ops mv88e6341_ops = {
.port_set_cmode = mv88e6341_port_set_cmode,
.port_setup_message_port = mv88e6xxx_setup_message_port,
.stats_snapshot = mv88e6390_g1_stats_snapshot,
- .stats_set_histogram = mv88e6095_g1_stats_set_histogram,
+ .stats_set_histogram = mv88e6390_g1_stats_set_histogram,
.stats_get_sset_count = mv88e6320_stats_get_sset_count,
.stats_get_strings = mv88e6320_stats_get_strings,
.stats_get_stats = mv88e6390_stats_get_stats,
--
2.31.1
next prev parent reply other threads:[~2021-06-30 22:22 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-30 17:43 [PATCH net 0/6] dsa: mv88e6xxx: Topaz fixes Marek Behún
2021-06-30 17:43 ` [PATCH net 1/6] net: dsa: mv88e6xxx: enable .port_set_policy() on Topaz Marek Behún
2021-06-30 20:02 ` Andrew Lunn
2021-06-30 17:43 ` [PATCH net 2/6] net: dsa: mv88e6xxx: use correct .stats_set_histogram() " Marek Behún
2021-06-30 20:03 ` Andrew Lunn
2021-06-30 17:43 ` [PATCH net 3/6] net: dsa: mv88e6xxx: enable .rmu_disable() " Marek Behún
2021-06-30 20:07 ` Andrew Lunn
2021-06-30 17:43 ` [PATCH net 4/6] net: dsa: mv88e6xxx: enable devlink ATU hash param for Topaz Marek Behún
2021-06-30 20:08 ` Andrew Lunn
2021-06-30 17:43 ` [PATCH net 5/6] net: dsa: mv88e6xxx: enable SerDes RX stats " Marek Behún
2021-06-30 20:08 ` Andrew Lunn
2021-06-30 22:15 ` Marek Behún
2021-06-30 17:43 ` [PATCH net 6/6] net: dsa: mv88e6xxx: enable SerDes PCS register dump via ethtool -d on Topaz Marek Behún
2021-06-30 20:10 ` Andrew Lunn
2021-06-30 22:22 ` [PATCH net v2 0/6] dsa: mv88e6xxx: Topaz fixes Marek Behún
2021-06-30 22:22 ` [PATCH net v2 1/6] net: dsa: mv88e6xxx: enable .port_set_policy() on Topaz Marek Behún
2021-06-30 22:22 ` Marek Behún [this message]
2021-06-30 22:22 ` [PATCH net v2 3/6] net: dsa: mv88e6xxx: enable .rmu_disable() " Marek Behún
2021-06-30 22:22 ` [PATCH net v2 4/6] net: dsa: mv88e6xxx: enable devlink ATU hash param for Topaz Marek Behún
2021-06-30 22:22 ` [PATCH net v2 5/6] net: dsa: mv88e6xxx: enable SerDes RX stats " Marek Behún
2021-06-30 22:22 ` [PATCH net v2 6/6] net: dsa: mv88e6xxx: enable SerDes PCS register dump via ethtool -d on Topaz Marek Behún
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210630222231.2297-3-kabel@kernel.org \
--to=kabel@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).