From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46891C11F6A for ; Fri, 2 Jul 2021 08:30:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1AF4661420 for ; Fri, 2 Jul 2021 08:30:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230429AbhGBId3 (ORCPT ); Fri, 2 Jul 2021 04:33:29 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:47679 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230236AbhGBId1 (ORCPT ); Fri, 2 Jul 2021 04:33:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1625214655; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ebqrOg7XijUonFvzMVuLSVbgtaPdYEqUj8mLxx77yyo=; b=ewss+1ddADuTOh9/jD1tYSdf8kNlgGrofnTM23vEbUuJZkaBcLR143EqfHwYHAow9pZsHA 8V2jFl+ypXb2hsfbYLI1yCvHNhRENKA9LtuvRn+XoeiTxJ/SaD8t+KEKMcfcNVexDUjshh rHS4Y3O9m6DtRPMAC6GKjZKRZpPXvqM= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-367-gQqewFA_PsOUq-U5pBOoGA-1; Fri, 02 Jul 2021 04:30:53 -0400 X-MC-Unique: gQqewFA_PsOUq-U5pBOoGA-1 Received: by mail-wm1-f69.google.com with SMTP id u64-20020a1cdd430000b02901ed0109da5fso5953166wmg.4 for ; Fri, 02 Jul 2021 01:30:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=ebqrOg7XijUonFvzMVuLSVbgtaPdYEqUj8mLxx77yyo=; b=iUSoEA54COkHFn1fn0uBXnrK1JMmmRLWiafNtafnpeWQLji2JXSjiOL4JcQ4RJDHEc NuqKDWS9fPpFXfj9143h6Swa451io44Q+crp+f8fZJcGXzvQVhUKdUbedRohPhmqsbQf X8ZBrI9heVGrL8cXsfLoQXEiL07+ivKtVGtTgIhizZELCMcKX2SkAWLGr/B/CGwDEAoL Dphl04e/sWXqyb8NpLqyVlrATGfjSlXzCLyy13fquJlIfQ4rkZZKB7gU1najGOCqDp+E RSa1PUmQOkDir2c9nku+9wv0cwXwkXHOg2SGihQ/AIOYQE2b7Ik1Xa61vhplp70VYKXZ 9RaA== X-Gm-Message-State: AOAM530CB42py1XgARKfbX157JppcyocOmh3eMyi9jGdvN5P2rrKmogk aTf4xE5df5Ijz2qj7WX2WDIBO4jeunf1BGKs2UYoq7N5nSvH6r2sJLLdrPCXy0DMG3wk4wWJM/8 haOkO1zmbkN76ttMk X-Received: by 2002:adf:e6c4:: with SMTP id y4mr1967238wrm.4.1625214652751; Fri, 02 Jul 2021 01:30:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx8uIwBip3ssxhZ0C7gznIuoJUVg/I2BZmKaIPk2T4beqCdTMa/NQLxn0hIFA0PybOGMb40GA== X-Received: by 2002:adf:e6c4:: with SMTP id y4mr1967207wrm.4.1625214652525; Fri, 02 Jul 2021 01:30:52 -0700 (PDT) Received: from redhat.com ([2.55.143.136]) by smtp.gmail.com with ESMTPSA id k6sm897496wrx.41.2021.07.02.01.30.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Jul 2021 01:30:51 -0700 (PDT) Date: Fri, 2 Jul 2021 04:30:46 -0400 From: "Michael S. Tsirkin" To: Yunsheng Lin Cc: Jason Wang , davem@davemloft.net, kuba@kernel.org, brouer@redhat.com, paulmck@kernel.org, peterz@infradead.org, will@kernel.org, shuah@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-kselftest@vger.kernel.org, linuxarm@openeuler.org Subject: Re: [PATCH net-next v3 1/3] selftests/ptr_ring: add benchmark application for ptr_ring Message-ID: <20210702042838-mutt-send-email-mst@kernel.org> References: <1625142402-64945-1-git-send-email-linyunsheng@huawei.com> <1625142402-64945-2-git-send-email-linyunsheng@huawei.com> <91bcade8-f034-4bc7-f329-d5e1849867e7@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <91bcade8-f034-4bc7-f329-d5e1849867e7@huawei.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Jul 02, 2021 at 04:17:17PM +0800, Yunsheng Lin wrote: > > Let's reuse ptr_ring.c in tools/virtio/ringtest. Nothing virt specific there. > > It *does* have some virtio specific at the end of ptr_ring.c. > It can be argued that the ptr_ring.c in tools/virtio/ringtest > could be refactored to remove the function related to virtio. > > But as mentioned in the previous disscusion [1], the tools/virtio/ > seems to have compile error in the latest kernel, it does not seems > right to reuse that. > And most of testcase in tools/virtio/ seems > better be in tools/virtio/ringtest instead，so until the testcase > in tools/virtio/ is compile-error-free and moved to tools/testing/ > selftests/, it seems better not to reuse it for now. That's a great reason to reuse - so tools/virtio/ stays working. Please just fix that. -- MST