From: Phil Sutter <phil@nwl.cc>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: netdev@vger.kernel.org, Jamal Hadi Salim <jhs@mojatatu.com>
Subject: Re: [iproute PATCH] tc: u32: Fix key folding in sample option
Date: Mon, 5 Jul 2021 16:17:40 +0200 [thread overview]
Message-ID: <20210705141740.GI3673@orbyte.nwl.cc> (raw)
In-Reply-To: <20210202183051.21022-1-phil@nwl.cc>
Hi,
On Tue, Feb 02, 2021 at 07:30:51PM +0100, Phil Sutter wrote:
> In between Linux kernel 2.4 and 2.6, key folding for hash tables changed
> in kernel space. When iproute2 dropped support for the older algorithm,
> the wrong code was removed and kernel 2.4 folding method remained in
> place. To get things functional for recent kernels again, restoring the
> old code alone was not sufficient - additional byteorder fixes were
> needed.
>
> While being at it, make use of ffs() and thereby align the code with how
> kernel determines the shift width.
>
> Fixes: 267480f55383c ("Backout the 2.4 utsname hash patch.")
> Signed-off-by: Phil Sutter <phil@nwl.cc>
Seems this patch fell off the table? Or was there an objection I missed?
FWIW, the related kernel selftests patch[1] which asserts this patch's
change is upstream already.
Cheers, Phil
[1] 373e13bc63639 ("selftests: tc-testing: u32: Add tests covering
sample option")
next prev parent reply other threads:[~2021-07-05 14:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-02 18:30 [iproute PATCH] tc: u32: Fix key folding in sample option Phil Sutter
2021-02-04 13:19 ` Jamal Hadi Salim
2021-02-04 14:04 ` Phil Sutter
2021-02-04 14:34 ` Jamal Hadi Salim
2021-02-04 14:36 ` Jamal Hadi Salim
2021-02-04 14:50 ` Phil Sutter
2021-02-04 15:28 ` Jamal Hadi Salim
2021-02-04 16:50 ` Phil Sutter
2021-02-04 18:08 ` Jamal Hadi Salim
2021-07-05 14:17 ` Phil Sutter [this message]
2021-07-05 17:25 ` Jamal Hadi Salim
2021-08-03 16:42 ` Phil Sutter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210705141740.GI3673@orbyte.nwl.cc \
--to=phil@nwl.cc \
--cc=jhs@mojatatu.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).