From: Stephen Hemminger <stephen@networkplumber.org>
To: Alexander Mikhalitsyn <alexander.mikhalitsyn@virtuozzo.com>
Cc: netdev@vger.kernel.org, David Ahern <dsahern@gmail.com>,
Andrei Vagin <avagin@gmail.com>,
Alexander Mikhalitsyn <alexander@mihalicyn.com>
Subject: Re: [PATCHv4 iproute2] ip route: ignore ENOENT during save if RT_TABLE_MAIN is being dumped
Date: Tue, 6 Jul 2021 08:34:07 -0700 [thread overview]
Message-ID: <20210706083407.76deb4c0@hermes.local> (raw)
In-Reply-To: <20210629155116.23464-1-alexander.mikhalitsyn@virtuozzo.com>
On Tue, 29 Jun 2021 18:51:15 +0300
Alexander Mikhalitsyn <alexander.mikhalitsyn@virtuozzo.com> wrote:
> + const struct rtnl_dump_filter_arg a[2] = {
> + { .filter = filter, .arg1 = arg1,
> + .errhndlr = errhndlr, .arg2 = arg2, .nc_flags = nc_flags, },
> + { .filter = NULL, .arg1 = NULL,
> + .errhndlr = NULL, .arg2 = NULL, .nc_flags = 0, },
> };
I am OK with this as is. But you don't need to add initializers for fields
that are 0/NULL (at least in C).
So could be:
const struct rtnl_dump_filter_arg a[] = {
{ .filter = filter, .arg1 = arg1,
.errhndlr = errhndlr, .arg2 = arg2, .nc_flags = nc_flags, },
{ },
};
next prev parent reply other threads:[~2021-07-06 15:34 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-22 15:03 [PATCH iproute2] ip route: ignore ENOENT during save if RT_TABLE_MAIN is being dumped Alexander Mikhalitsyn
2021-06-23 15:36 ` David Ahern
2021-06-23 16:11 ` Alexander Mikhalitsyn
2021-06-24 15:28 ` [PATCHv2 " Alexander Mikhalitsyn
2021-06-24 15:36 ` Stephen Hemminger
2021-06-24 15:40 ` Alexander Mikhalitsyn
2021-06-25 10:59 ` Alexander Mikhalitsyn
2021-06-25 10:44 ` [PATCHv3 " Alexander Mikhalitsyn
2021-06-27 21:54 ` Stephen Hemminger
2021-06-28 6:31 ` Alexander Mikhalitsyn
2021-06-28 17:17 ` Stephen Hemminger
2021-06-28 17:21 ` Alexander Mikhalitsyn
2021-06-29 15:51 ` [PATCHv4 " Alexander Mikhalitsyn
2021-07-06 7:47 ` Alexander Mikhalitsyn
2021-07-06 15:34 ` Stephen Hemminger [this message]
2021-07-06 15:44 ` Alexander Mikhalitsyn
2021-07-06 16:18 ` Stephen Hemminger
2021-07-06 17:17 ` Alexander Mikhalitsyn
2021-07-07 0:05 ` Stephen Hemminger
2021-07-07 12:22 ` Alexander Mikhalitsyn
2021-07-07 14:31 ` Stephen Hemminger
2021-07-07 14:32 ` Alexander Mikhalitsyn
2021-07-07 12:09 ` [PATCHv5 " Alexander Mikhalitsyn
2021-07-07 12:22 ` Alexander Mikhalitsyn
2021-07-07 14:35 ` Stephen Hemminger
2021-07-07 14:38 ` Alexander Mikhalitsyn
2021-07-07 14:50 ` patchwork-bot+netdevbpf
2021-07-11 10:59 ` Roi Dayan
2021-07-11 11:09 ` Roi Dayan
2021-07-11 11:12 ` Alexander Mihalicyn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210706083407.76deb4c0@hermes.local \
--to=stephen@networkplumber.org \
--cc=alexander.mikhalitsyn@virtuozzo.com \
--cc=alexander@mihalicyn.com \
--cc=avagin@gmail.com \
--cc=dsahern@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).