From: Hangbin Liu <liuhangbin@gmail.com>
To: netdev@vger.kernel.org
Cc: David Ahern <dsahern@kernel.org>, Hangbin Liu <liuhangbin@gmail.com>
Subject: [PATCH net 0/2] Fix selftests icmp_redirect.sh failures
Date: Wed, 7 Jul 2021 16:15:28 +0800 [thread overview]
Message-ID: <20210707081530.1107289-1-liuhangbin@gmail.com> (raw)
This patchset fixes 2 failures for selftests icmp_redirect.sh.
The first patch is for IPv6 redirecting tests. When disable option
CONFIG_IPV6_SUBTREES, there is not "from ::" info in ip route output.
So we should not check this key word.
The second patch is for testing "mtu exception plus redirect", which do
a PMTU update first and do redirect second. For topology like
(MTU 1300)
|----- R1_1 -------- R1_2 --------|
H1 ---| | ---- H2 (MTU 1500)
|----- R2_1 -------- R2_2 --------|
After redirecting to R2 patch, the PMTU info in R1 path should be cleard.
So we should not check PMTU info for test "mtu exception plus redirect".
After the fixes, all the test passed now
]# ./icmp_redirect.sh
###########################################################################
Legacy routing
###########################################################################
TEST: IPv4: redirect exception [ OK ]
TEST: IPv6: redirect exception [ OK ]
TEST: IPv4: redirect exception plus mtu [ OK ]
TEST: IPv6: redirect exception plus mtu [ OK ]
TEST: IPv4: routing reset [ OK ]
TEST: IPv6: routing reset [ OK ]
TEST: IPv4: mtu exception [ OK ]
TEST: IPv6: mtu exception [ OK ]
TEST: IPv4: mtu exception plus redirect [ OK ]
TEST: IPv6: mtu exception plus redirect [ OK ]
[...]
###########################################################################
Routing with nexthop objects and VRF
###########################################################################
TEST: IPv4: redirect exception [ OK ]
TEST: IPv6: redirect exception [ OK ]
TEST: IPv4: redirect exception plus mtu [ OK ]
TEST: IPv6: redirect exception plus mtu [ OK ]
TEST: IPv4: routing reset [ OK ]
TEST: IPv6: routing reset [ OK ]
TEST: IPv4: mtu exception [ OK ]
TEST: IPv6: mtu exception [ OK ]
TEST: IPv4: mtu exception plus redirect [ OK ]
TEST: IPv6: mtu exception plus redirect [ OK ]
Tests passed: 40
Tests failed: 0
Tests xfailed: 0
Hangbin Liu (2):
selftests: icmp_redirect: remove from checking for IPv6 route get
selftests: icmp_redirect: IPv6 PMTU info should be cleared after
redirect
tools/testing/selftests/net/icmp_redirect.sh | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
--
2.31.1
next reply other threads:[~2021-07-07 8:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-07 8:15 Hangbin Liu [this message]
2021-07-07 8:15 ` [PATCH net 1/2] selftests: icmp_redirect: remove from checking for IPv6 route get Hangbin Liu
2021-07-07 14:49 ` David Ahern
2021-07-07 8:15 ` [PATCH net 2/2] selftests: icmp_redirect: IPv6 PMTU info should be cleared after redirect Hangbin Liu
2021-07-07 14:51 ` David Ahern
2021-07-07 20:51 ` [PATCH net 0/2] Fix selftests icmp_redirect.sh failures patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210707081530.1107289-1-liuhangbin@gmail.com \
--to=liuhangbin@gmail.com \
--cc=dsahern@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).