From: David Miller <davem@davemloft.net>
To: xiyou.wangcong@gmail.com
Cc: netdev@vger.kernel.org, qitao.xu@bytedance.com, cong.wang@bytedance.com
Subject: Re: [Patch net-next] net: use %px to print skb address in trace_netif_receive_skb
Date: Fri, 09 Jul 2021 01:16:25 -0700 (PDT) [thread overview]
Message-ID: <20210709.011625.1604833283174788576.davem@davemloft.net> (raw)
In-Reply-To: <20210709051710.15831-1-xiyou.wangcong@gmail.com>
From: Cong Wang <xiyou.wangcong@gmail.com>
Date: Thu, 8 Jul 2021 22:17:08 -0700
> From: Qitao Xu <qitao.xu@bytedance.com>
>
> The print format of skb adress in tracepoint class net_dev_template
> is changed to %px from %p, because we want to use skb address
> as a quick way to identify a packet.
>
> Reviewed-by: Cong Wang <cong.wang@bytedance.com>
> Signed-off-by: Qitao Xu <qitao.xu@bytedance.com>
Aren't we not supposed to leak kernel addresses to userspace?
next prev parent reply other threads:[~2021-07-09 8:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-09 5:17 [Patch net-next] net: use %px to print skb address in trace_netif_receive_skb Cong Wang
2021-07-09 5:17 ` [Patch net-next] net_sched: use %px to print skb address in trace_qdisc_dequeue() Cong Wang
2021-07-09 5:17 ` [Patch net-next] net_sched: introduce tracepoint trace_qdisc_enqueue() Cong Wang
2021-07-09 8:16 ` David Miller [this message]
2021-07-09 18:59 ` [Patch net-next] net: use %px to print skb address in trace_netif_receive_skb Cong Wang
2021-07-09 19:18 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210709.011625.1604833283174788576.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=cong.wang@bytedance.com \
--cc=netdev@vger.kernel.org \
--cc=qitao.xu@bytedance.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).