From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D9B0C07E99 for ; Fri, 9 Jul 2021 08:16:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 012EF613C7 for ; Fri, 9 Jul 2021 08:16:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231438AbhGIITQ (ORCPT ); Fri, 9 Jul 2021 04:19:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59774 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231278AbhGIITP (ORCPT ); Fri, 9 Jul 2021 04:19:15 -0400 Received: from mail.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C63FDC0613DD for ; Fri, 9 Jul 2021 01:16:32 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) by mail.monkeyblade.net (Postfix) with ESMTPSA id 6755C4D310810; Fri, 9 Jul 2021 01:16:29 -0700 (PDT) Date: Fri, 09 Jul 2021 01:16:25 -0700 (PDT) Message-Id: <20210709.011625.1604833283174788576.davem@davemloft.net> To: xiyou.wangcong@gmail.com Cc: netdev@vger.kernel.org, qitao.xu@bytedance.com, cong.wang@bytedance.com Subject: Re: [Patch net-next] net: use %px to print skb address in trace_netif_receive_skb From: David Miller In-Reply-To: <20210709051710.15831-1-xiyou.wangcong@gmail.com> References: <20210709051710.15831-1-xiyou.wangcong@gmail.com> X-Mailer: Mew version 6.8 on Emacs 27.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.6.2 (mail.monkeyblade.net [0.0.0.0]); Fri, 09 Jul 2021 01:16:29 -0700 (PDT) Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Cong Wang Date: Thu, 8 Jul 2021 22:17:08 -0700 > From: Qitao Xu > > The print format of skb adress in tracepoint class net_dev_template > is changed to %px from %p, because we want to use skb address > as a quick way to identify a packet. > > Reviewed-by: Cong Wang > Signed-off-by: Qitao Xu Aren't we not supposed to leak kernel addresses to userspace?