From: Pavel Skripkin <paskripkin@gmail.com>
To: Timur Tabi <timur@kernel.org>
Cc: David Miller <davem@davemloft.net>,
kuba@kernel.org, netdev <netdev@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] net: qcom/emac: fix UAF in emac_remove
Date: Sat, 10 Jul 2021 09:57:17 +0300 [thread overview]
Message-ID: <20210710095717.140ec45a@gmail.com> (raw)
In-Reply-To: <CAOZdJXWm4=UHw42YjUAQLZTNd=qbxyRag7-MJ5V4aq_xf8-1Vw@mail.gmail.com>
On Sat, 10 Jul 2021 00:02:26 -0500
Timur Tabi <timur@kernel.org> wrote:
> On Fri, Jul 9, 2021 at 9:24 AM Pavel Skripkin <paskripkin@gmail.com>
> wrote:
> >
> > adpt is netdev private data and it cannot be
> > used after free_netdev() call. Using adpt after free_netdev()
> > can cause UAF bug. Fix it by moving free_netdev() at the end of the
> > function.
>
> Please spell out what "UAF" means, thanks. If you fix that, then
>
> Acked-by: Timur Tabi <timur@kernel.org>
>
> Thanks.
Hi, Timur!
Thank you for feedback.
David has already applied this pacth. So, should I send v2 or maybe
revert + v2? I haven't been in such situations yet :)
With regards,
Pavel Skripkin
next prev parent reply other threads:[~2021-07-10 6:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-09 14:24 [PATCH] net: qcom/emac: fix UAF in emac_remove Pavel Skripkin
2021-07-09 18:30 ` patchwork-bot+netdevbpf
2021-07-10 5:02 ` Timur Tabi
2021-07-10 6:57 ` Pavel Skripkin [this message]
2021-07-10 15:20 ` Timur Tabi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210710095717.140ec45a@gmail.com \
--to=paskripkin@gmail.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=timur@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).