From: Cong Wang <xiyou.wangcong@gmail.com>
To: netdev@vger.kernel.org
Cc: Qitao Xu <qitao.xu@bytedance.com>,
Cong Wang <cong.wang@bytedance.com>,
Jesper Dangaard Brouer <brouer@redhat.com>
Subject: [Patch net-next v2] net_sched: use %px to print skb address in trace_qdisc_dequeue()
Date: Sun, 11 Jul 2021 11:32:34 -0700 [thread overview]
Message-ID: <20210711183234.7889-2-xiyou.wangcong@gmail.com> (raw)
In-Reply-To: <20210711183234.7889-1-xiyou.wangcong@gmail.com>
From: Qitao Xu <qitao.xu@bytedance.com>
Print format of skbaddr is changed to %px from %p, because we want
to use skb address as a quick way to identify a packet.
Note, trace ring buffer is only accessible to privileged users,
it is safe to use a real kernel address here.
Reviewed-by: Cong Wang <cong.wang@bytedance.com>
Cc: Jesper Dangaard Brouer <brouer@redhat.com>
Signed-off-by: Qitao Xu <qitao.xu@bytedance.com>
---
include/trace/events/qdisc.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/trace/events/qdisc.h b/include/trace/events/qdisc.h
index 330d32d84485..58209557cb3a 100644
--- a/include/trace/events/qdisc.h
+++ b/include/trace/events/qdisc.h
@@ -41,7 +41,7 @@ TRACE_EVENT(qdisc_dequeue,
__entry->txq_state = txq->state;
),
- TP_printk("dequeue ifindex=%d qdisc handle=0x%X parent=0x%X txq_state=0x%lX packets=%d skbaddr=%p",
+ TP_printk("dequeue ifindex=%d qdisc handle=0x%X parent=0x%X txq_state=0x%lX packets=%d skbaddr=%px",
__entry->ifindex, __entry->handle, __entry->parent,
__entry->txq_state, __entry->packets, __entry->skbaddr )
);
--
2.27.0
prev parent reply other threads:[~2021-07-11 18:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-11 18:32 [Patch net-next v2] net: use %px to print skb address in trace_netif_receive_skb Cong Wang
2021-07-11 18:32 ` Cong Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210711183234.7889-2-xiyou.wangcong@gmail.com \
--to=xiyou.wangcong@gmail.com \
--cc=brouer@redhat.com \
--cc=cong.wang@bytedance.com \
--cc=netdev@vger.kernel.org \
--cc=qitao.xu@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).