From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, Ioana Ciornei <ioana.ciornei@nxp.com>,
Jakub Kicinski <kuba@kernel.org>
Subject: Re: [PATCH net-next] net: dpaa2-mac: add support for more ethtool 10G link modes
Date: Tue, 20 Jul 2021 15:11:34 +0100 [thread overview]
Message-ID: <20210720141134.GT22278@shell.armlinux.org.uk> (raw)
In-Reply-To: <YPbU59Kmpk0NvlQH@lunn.ch>
On Tue, Jul 20, 2021 at 03:51:35PM +0200, Andrew Lunn wrote:
> On Tue, Jul 20, 2021 at 10:57:43AM +0100, Russell King wrote:
> > Phylink documentation says:
> > Note that the PHY may be able to transform from one connection
> > technology to another, so, eg, don't clear 1000BaseX just
> > because the MAC is unable to BaseX mode. This is more about
> > clearing unsupported speeds and duplex settings. The port modes
> > should not be cleared; phylink_set_port_modes() will help with this.
> >
> > So add the missing 10G modes.
>
> Hi Russell
>
> Would a phylink_set_10g(mask) helper make sense? As you say, it is
> about the speed, not the individual modes.
Yes, good point, and that will probably help avoid this in the future.
We can't do that for things like e.g. SGMII though, because 1000/half
isn't universally supported.
Shall we get this patch merged anyway and then clean it up - as such
a change will need to cover multiple drivers anyway?
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2021-07-20 14:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-20 9:57 [PATCH net-next] net: dpaa2-mac: add support for more ethtool 10G link modes Russell King
2021-07-20 13:51 ` Andrew Lunn
2021-07-20 14:11 ` Russell King (Oracle) [this message]
2021-07-20 14:13 ` Andrew Lunn
2021-08-16 14:47 ` Ioana Ciornei
2021-09-03 10:33 ` Russell King (Oracle)
2021-09-03 11:09 ` Ioana Ciornei
2021-09-03 11:34 ` Russell King (Oracle)
2021-09-03 13:11 ` Andrew Lunn
2021-09-03 17:06 ` Ioana Ciornei
2021-07-20 14:13 ` Andrew Lunn
-- strict thread matches above, loose matches on Subject: below --
2021-03-09 15:35 Russell King
2021-03-10 2:01 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210720141134.GT22278@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=ioana.ciornei@nxp.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).