From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DC97C636C8 for ; Tue, 20 Jul 2021 17:37:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4750761003 for ; Tue, 20 Jul 2021 17:37:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231147AbhGTQ4u (ORCPT ); Tue, 20 Jul 2021 12:56:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57118 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231438AbhGTQ4P (ORCPT ); Tue, 20 Jul 2021 12:56:15 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 674B9C061574 for ; Tue, 20 Jul 2021 10:36:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=6VrSyfc/kzenZzt/pZGMg0ZJJpLG3nvAIKa9l5luxTs=; b=Gg8i7G8gvve1BXewuvHzVMUrt g1WiI6ar7l+8xFEZ11cvumWf/jZa1Sax8DaFAIzdV4c8CM3j/dFjxiRHD0ppnROJ98ZIAezsDO46m HeKLmT6/9cv4AHJq9GeqMKz1hyy5YCcH0iwOd3masSN6CfPJJUgYDnys8DHf4geZK4D4gkAapR9BI ev/LesKXc7EcXvf42LUrQMGcJmCwELrq/rcrOliFZxJEzUB0r6FTHzYgOUSkuIFYYgzad/T0CyVYU mb95ApsMv5mrb3CBf7ROWoFxD4SpbEbxDmP/FeSs5CRFA2eSR2EZYJqz7ITuL3KwsotYssq4nC2Ig Uw3TXDgRQ==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:46378) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m5tfl-0006hd-Es; Tue, 20 Jul 2021 18:36:49 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1m5tfk-00075T-JT; Tue, 20 Jul 2021 18:36:48 +0100 Date: Tue, 20 Jul 2021 18:36:48 +0100 From: "Russell King (Oracle)" To: Vladimir Oltean Cc: netdev@vger.kernel.org, Jakub Kicinski , "David S. Miller" , Andrew Lunn , Heiner Kallweit , Fabio Estevam Subject: Re: [PATCH net-next] net: phy: at803x: finish the phy id checking simplification Message-ID: <20210720173648.GW22278@shell.armlinux.org.uk> References: <20210720172433.995912-1-vladimir.oltean@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210720172433.995912-1-vladimir.oltean@nxp.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: Russell King (Oracle) Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Jul 20, 2021 at 08:24:33PM +0300, Vladimir Oltean wrote: > The blamed commit was probably not tested on net-next, since it did not > refactor the extra phy id check introduced in commit b856150c8098 ("net: > phy: at803x: mask 1000 Base-X link mode"). > > Fixes: 8887ca5474bd ("net: phy: at803x: simplify custom phy id matching") > Signed-off-by: Vladimir Oltean Thanks for catching this and sorry for the breakage - the humidity in the UK is getting to me (particularly causing tiredness), so I've obviously missed stuff. :( Acked-by: Russell King (Oracle) -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!