From: "Marek Behún" <kabel@kernel.org>
To: "Russell King (Oracle)" <linux@armlinux.org.uk>
Cc: Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>
Subject: Re: [PATCH RFC net-next] net: phy: marvell10g: add downshift tunable support
Date: Tue, 20 Jul 2021 19:50:21 +0200 [thread overview]
Message-ID: <20210720195021.62feacb4@dellmb> (raw)
In-Reply-To: <20210720173941.GX22278@shell.armlinux.org.uk>
On Tue, 20 Jul 2021 18:39:41 +0100
"Russell King (Oracle)" <linux@armlinux.org.uk> wrote:
> I was intending to leave the firmware version check where it was and
> just add a flag to say "this has downshift". The older firmwares on
> 3310 are basically buggy - they do downshift but only from 1G to 100M,
> they fail to go to 10M.
So we have two options
* do the firmware version comparison at the position where the given
feature is being configured
* do the firmware version comparison in probe method and set specific
flags for all features
The second option is better if different PHYs have differnet system of
versioning, but this can potentially lead to many different flags.
I'll leave this decision to you.
> > BTW would you agree with a patch renaming the mv3310_ prefixes to
> > mv10g_ for all functions that are generic to both mv3310_ and
> > mv2110_?
> > I was thinking about such a thing because it has become rather
> > confusing.
>
> I've been thinking the same thing actually.
OK I will send a patch then once your downshift patch is applied.
Marek
prev parent reply other threads:[~2021-07-20 17:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-20 13:38 [PATCH RFC net-next] net: phy: marvell10g: add downshift tunable support Russell King
2021-07-20 14:28 ` Andrew Lunn
2021-07-20 14:30 ` Russell King (Oracle)
2021-07-20 15:04 ` Marek Behún
2021-07-20 17:14 ` Russell King (Oracle)
2021-07-20 17:32 ` Marek Behún
2021-07-20 17:39 ` Russell King (Oracle)
2021-07-20 17:50 ` Marek Behún [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210720195021.62feacb4@dellmb \
--to=kabel@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox