From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D65D4C432BE for ; Tue, 3 Aug 2021 02:29:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BFD9561037 for ; Tue, 3 Aug 2021 02:29:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233645AbhHCC3h (ORCPT ); Mon, 2 Aug 2021 22:29:37 -0400 Received: from mail.kernel.org ([198.145.29.99]:59086 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233769AbhHCC3U (ORCPT ); Mon, 2 Aug 2021 22:29:20 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id E1A21610A2; Tue, 3 Aug 2021 02:29:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1627957746; bh=Rp/gFsnEkqzoyS58loewmelE0QntFJqyP1+lHb2xeh0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=PeEKuegyGK67D1G7KaqqY1qOif189UJKR7gNDuBik+sulpJGL1LkC/acrst0FkIKA cVjUx6tJQoxLOugWY24sUZcmdPq6h53266biF++7xZ4EFQt+vXGKAzw4Lsty0DiMTq g5Ph3C8SPTIVIJMvRJnXljdSY0btbQ4fGsznT8HGS00OXfiu5WZ/HdxXcsZYrqxqrO Dz9OT3JnbY167W1rOiwAsBQNF1msnM0KnTYlvJsVCL5DnsamePulY4NBr0MZz8MtQZ EB2zIxL8XU4w0gTZ7g0/YptWpu21qLSRC+jzeCMklUg0qoEAG2n7Jk1z3aXFpDRKBU YBRDGqs/qEvNQ== From: Saeed Mahameed To: "David S. Miller" , Jakub Kicinski Cc: netdev@vger.kernel.org, Roi Dayan , Maor Dickman , Saeed Mahameed Subject: [net-next 14/16] net/mlx5e: Remove redundant assignment of counter to null Date: Mon, 2 Aug 2021 19:28:51 -0700 Message-Id: <20210803022853.106973-15-saeed@kernel.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210803022853.106973-1-saeed@kernel.org> References: <20210803022853.106973-1-saeed@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Roi Dayan counter is being initialized before being used. Signed-off-by: Roi Dayan Reviewed-by: Maor Dickman Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c index 472c0c756a69..980a668bbc3c 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c @@ -1037,7 +1037,7 @@ mlx5e_tc_add_nic_flow(struct mlx5e_priv *priv, struct mlx5e_tc_flow_parse_attr *parse_attr; struct mlx5_flow_attr *attr = flow->attr; struct mlx5_core_dev *dev = priv->mdev; - struct mlx5_fc *counter = NULL; + struct mlx5_fc *counter; int err; parse_attr = attr->parse_attr; @@ -1361,9 +1361,9 @@ mlx5e_tc_add_fdb_flow(struct mlx5e_priv *priv, bool vf_tun = false, encap_valid = true; struct net_device *encap_dev = NULL; struct mlx5_esw_flow_attr *esw_attr; - struct mlx5_fc *counter = NULL; struct mlx5e_rep_priv *rpriv; struct mlx5e_priv *out_priv; + struct mlx5_fc *counter; u32 max_prio, max_chain; int err = 0; int out_index; -- 2.31.1