Re: [PATCH v3 net-next 05/10] net: dsa: microchip: add DSA support for microchip lan937x

Andrew Lunn
2021-08-03T14:43:55Z

On Tue, Aug 03, 2021 at 12:33:53AM +0300, Vladimir Oltean wrote:
> On Sun, Aug 01, 2021 at 12:05:16AM +0200, Andrew Lunn wrote:
> > > So you support both the cases where an internal PHY is described using
> > > OF bindings, and where the internal PHY is implicitly accessed using the
> > > slave_mii_bus of the switch, at a PHY address equal to the port number,
> > > and with no phy-handle or fixed-link device tree property for that port?
> > >
> > > Do you need both alternatives? The first is already more flexible than
> > > the second.
> >
> > The first is also much more verbose in DT, and the second generally
> > just works without any DT. What can be tricky with the second is
> > getting PHY interrupts to work, but it is possible, the mv88e6xxx does
> > it.
>
> - The explicit phy-handle is more verbose as far as the DT description
> goes for one particular use case of indirect internal PHY access, but
> it also leads to less complex code (more uniform with other usage
> patterns in the kernel). What is tricky with an implicit phy-handle is
> trivial without it. This makes a difference with DM_DSA in U-Boot,
> where I would really like to avoid bloating the code and just support
> 2 options for a DSA switch port: either a phy-handle or a fixed-link.
> These two are already "Turing-complete" (they can describe any system)
> so I only see the implicit phy-handle as a helping hand for a few lazy
> DT writers. Since I have been pushing back that we shouldn't bloat
> U-Boot with implicit phy-handle logic when it doesn't give a concrete
> benefit, and have gotten a push back in return that Linux does allow
> it and it would be desirable for one DT binding to cover all, I now
> need to promote the more generic approach for Linux going forward too.
>
> - If the switch has the ability for its internal PHYs to be accessed
> directly over MDIO pins instead of using indirect SPI transfers, using
> a phy-handle is a generic way to handle both cases, while the implicit
> phy-handle does not give you that option.
>
> - If there is complex pinmuxing in the SoC and one port can either be
> connected to an internal 100base-T1 or to a 100base-TX PHY, and this
> is not detectable by software, this cannot be dealt with using an
> implicit phy-handle if the 100base-T1 and 100base-TX PHYs are not at
> the same address.
>
> - In general, if the internal PHYs are not at an MDIO address equal to
> the port number, this cannot be dealt with using the implicit
> phy-handle method.

There are good reasons to use an explicit phy-handle, and i would
never block such code. However, implicit is historically how it was
done. There are many DT blobs which assume it works. So implicit is
not going away.

If you want to only support explicit in U-Boot, that is fine. I would
suggest making this clear in the U-Boot documentation.

Andrew