From: Kees Cook <keescook@chromium.org>
To: Stanislav Yakovlev <stas.yakovlev@gmail.com>
Cc: Kalle Valo <kvalo@codeaurora.org>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH] ipw2x00: Avoid field-overflowing memcpy()
Date: Fri, 6 Aug 2021 15:30:14 -0700 [thread overview]
Message-ID: <202108061529.07216CBF7@keescook> (raw)
In-Reply-To: <20210806200855.2870554-1-keescook@chromium.org>
On Fri, Aug 06, 2021 at 01:08:55PM -0700, Kees Cook wrote:
> - if (element_info == NULL)
> + if (!element_info || info_element || info_element->len != size - 2)
> return -1;
> - if (info_element == NULL)
> - return -1;
Gah, a let a typo in. (should be !info_element.) v2 coming...
--
Kees Cook
next prev parent reply other threads:[~2021-08-06 22:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-06 20:08 [PATCH] ipw2x00: Avoid field-overflowing memcpy() Kees Cook
2021-08-06 22:30 ` Kees Cook [this message]
2021-08-07 2:36 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202108061529.07216CBF7@keescook \
--to=keescook@chromium.org \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stas.yakovlev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).