From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B722C4338F for ; Tue, 10 Aug 2021 13:15:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 53C7261051 for ; Tue, 10 Aug 2021 13:15:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241116AbhHJNPV (ORCPT ); Tue, 10 Aug 2021 09:15:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46248 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229902AbhHJNPU (ORCPT ); Tue, 10 Aug 2021 09:15:20 -0400 Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6E79FC0613D3 for ; Tue, 10 Aug 2021 06:14:58 -0700 (PDT) Received: by mail-ed1-x532.google.com with SMTP id b7so30225489edu.3 for ; Tue, 10 Aug 2021 06:14:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=k8KPa8wUqbHL2sNHrpvn5Glgkqp7NU8IRQvthgqc8ns=; b=OBBEycdekfcK3BAK/ys/s8dRKYLizy6kHHCrwK3rAMSuVUtVwVY2gnHuydeeNSm4EV W44EKwJy1rDlNlDC5Li+3zxo1T/B5utCo1P1MiGAZ7W+pkNQBEi3RkELIqQMmR8yFcHg GEgDertmZsm82cDyUjIlB4wXcoSOM0DJHgPn4XaMCXjfYSZ+tuFyLnsmRndtl7c1SZDy IUQcHnJjLR5gGBJucajuoblWz+3qVYJNQwYpFYa9NFcnQumQ0Rg508KyyucRlNmEUYUK LQxuKf+Z1rfYBGvXVx1dPgkKmkrxCvlk5UC/t7BjUwFOSrAFg4XgP0sgwFiqgvFGn0Ss mIVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=k8KPa8wUqbHL2sNHrpvn5Glgkqp7NU8IRQvthgqc8ns=; b=r2EIfoJJIGjRJwc307GJrNawHm7eiz+kyOWZMrKevsn9p3ntgfWYaKeaWDnTbzA+HC qPCSkjOuDEFmdGG57YAwWIocElpQXIwDGKkxLB89+jPMcxznHxdIpdAXqLXBKJCDsNPy Hb6dp6LwNGOU59MV/5IEtV3dhwU8YBPUhlcPzCZakzEpGjdXsJ+QFYGLH9Vy0o2BhaLW Pt8jzUE9f+wMOSyTIGpCvvRk9SCjjogIiQPfCdQcYXBSsbn5pvaBRuNASLU7ZC0k3s6+ ODJL/+UzQYvw8wAGQNEu55NDbQuZAP7QrBPuiBoDOI+PtHnxXHFdpIHVfUAdPyk1E1Xl Nxhw== X-Gm-Message-State: AOAM5326wvYgPVIBzxmmcO5Xz98MNLI0OmcqulyRjl7k0+4RrT8Waktu tcfA1FROmLkeS7C1x0k5snA= X-Google-Smtp-Source: ABdhPJxqt7VOYKQwWlUQy52vaQ+KeYURQzlC3zq5CEkPfRMYFPMdxE7m8BWZR/XbgYmhfaSUjlB6ZA== X-Received: by 2002:a05:6402:26c6:: with SMTP id x6mr5060572edd.175.1628601297061; Tue, 10 Aug 2021 06:14:57 -0700 (PDT) Received: from skbuf ([188.25.144.60]) by smtp.gmail.com with ESMTPSA id g26sm3214293ejr.48.2021.08.10.06.14.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Aug 2021 06:14:56 -0700 (PDT) Date: Tue, 10 Aug 2021 16:14:54 +0300 From: Vladimir Oltean To: Florian Fainelli Cc: Vladimir Oltean , netdev@vger.kernel.org, Jakub Kicinski , "David S. Miller" , Andrew Lunn , Vivien Didelot , Kurt Kanzenbach , Woojung Huh , UNGLinuxDriver@microchip.com, Sean Wang , Landen Chao , DENG Qingfang , Matthias Brugger , Claudiu Manoil , Alexandre Belloni , George McCollister Subject: Re: [RFC PATCH net-next 4/4] net: dsa: b53: express b53_for_each_port in terms of dsa_switch_for_each_port Message-ID: <20210810131454.ytfcepfenttc357n@skbuf> References: <20210809190320.1058373-1-vladimir.oltean@nxp.com> <20210809190320.1058373-5-vladimir.oltean@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Aug 10, 2021 at 02:39:08AM -0700, Florian Fainelli wrote: > On 8/9/2021 12:03 PM, Vladimir Oltean wrote: > > Merging the two allows us to remove the open-coded > > "dev->enabled_ports & BIT(i)" check from b53_br_join and b53_br_leave, > > while still avoiding a quadratic iteration through the switch's ports. > > > > Sadly I don't know if it's possible to completely get rid of > > b53_for_each_port and replace it with dsa_switch_for_each_available_port, > > especially for the platforms that use pdata and not OF bindings. > > > > Signed-off-by: Vladimir Oltean > > We should really be able to eliminate b53_for_each_port() entirely, let me > try to submit a patch doing that when I come back from vacation or you can > do it, and if there are bugs, I will address them. I will let you do it when you come back, until then I believe the existing conversion has a fairly low risk of introducing any bugs.